Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [ob?] nto-tdep.c: recognize powerpc as well as rs6000
@ 2003-06-17 17:58 Kris Warkentin
  2003-06-17 18:17 ` Daniel Jacobowitz
  0 siblings, 1 reply; 5+ messages in thread
From: Kris Warkentin @ 2003-06-17 17:58 UTC (permalink / raw)
  To: Gdb-Patches@Sources.Redhat.Com

Since I'm braindead today....okay to commit?

cheers,

Kris

ChangeLog:

 * nto-tdep.c (nto_map_arch_to_cputype): Recognize "powerpc".
 (nto_find_and_open_solib): Likewise.
 (nto_init_solib_absolute_prefix): Likewise.
 (_initialize_nto_tdep): Fix indentation.

Index: nto-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/nto-tdep.c,v
retrieving revision 1.5
diff -c -r1.5 nto-tdep.c
*** nto-tdep.c 20 May 2003 21:34:56 -0000 1.5
--- nto-tdep.c 17 Jun 2003 17:54:05 -0000
***************
*** 72,78 ****
  {
    if (!strcmp (arch, "i386") || !strcmp (arch, "x86"))
      return CPUTYPE_X86;
!   if (!strcmp (arch, "rs6000") || !strcmp (arch, "ppc"))
      return CPUTYPE_PPC;
    if (!strcmp (arch, "mips"))
      return CPUTYPE_MIPS;
--- 72,78 ----
  {
    if (!strcmp (arch, "i386") || !strcmp (arch, "x86"))
      return CPUTYPE_X86;
!   if (!strcmp (arch, "rs6000") || !strcmp (arch, "powerpc"))
      return CPUTYPE_PPC;
    if (!strcmp (arch, "mips"))
      return CPUTYPE_MIPS;
***************
*** 97,103 ****
        arch = "x86";
        endian = "";
      }
!   else if (strcmp (TARGET_ARCHITECTURE->arch_name, "rs6000") == 0)
      {
        arch = "ppc";
        endian = "be";
--- 97,104 ----
        arch = "x86";
        endian = "";
      }
!   else if (strcmp (TARGET_ARCHITECTURE->arch_name, "rs6000") == 0 ||
!     strcmp (TARGET_ARCHITECTURE->arch_name, "powerpc") == 0)
      {
        arch = "ppc";
        endian = "be";
***************
*** 130,136 ****
        arch = "x86";
        endian = "";
      }
!   else if (strcmp (TARGET_ARCHITECTURE->arch_name, "rs6000") == 0)
      {
        arch = "ppc";
        endian = "be";
--- 131,138 ----
        arch = "x86";
        endian = "";
      }
!   else if (strcmp (TARGET_ARCHITECTURE->arch_name, "rs6000") == 0 ||
!     strcmp (TARGET_ARCHITECTURE->arch_name, "powerpc") == 0)
      {
        arch = "ppc";
        endian = "be";
***************
*** 269,275 ****
          int which, CORE_ADDR reg_addr)
  {
    nto_regset_t regset;
!   
  /* See corelow.c:get_core_registers for values of WHICH.  */
    if (which == 0)
      {
--- 271,277 ----
          int which, CORE_ADDR reg_addr)
  {
    nto_regset_t regset;
! 
  /* See corelow.c:get_core_registers for values of WHICH.  */
    if (which == 0)
      {
***************
*** 305,315 ****
  _initialize_nto_tdep (void)
  {
    add_setshow_cmd ("nto-debug", class_maintenance, var_zinteger,
!     &nto_internal_debugging, "Set QNX NTO internal debugging.\n\
  When non-zero, nto specific debug info is\n\
  displayed. Different information is displayed\n\
! for different positive values.",  "Show QNX NTO internal debugging.\n",
!     NULL, NULL, &setdebuglist, &showdebuglist);
  
    /* We use SIG45 for pulses, or something, so nostop, noprint
       and pass them.  */
--- 307,317 ----
  _initialize_nto_tdep (void)
  {
    add_setshow_cmd ("nto-debug", class_maintenance, var_zinteger,
!      &nto_internal_debugging, "Set QNX NTO internal debugging.\n\
  When non-zero, nto specific debug info is\n\
  displayed. Different information is displayed\n\
! for different positive values.", "Show QNX NTO internal debugging.\n",
!      NULL, NULL, &setdebuglist, &showdebuglist);
  
    /* We use SIG45 for pulses, or something, so nostop, noprint
       and pass them.  */




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ob?] nto-tdep.c: recognize powerpc as well as rs6000
  2003-06-17 17:58 [ob?] nto-tdep.c: recognize powerpc as well as rs6000 Kris Warkentin
@ 2003-06-17 18:17 ` Daniel Jacobowitz
  2003-06-17 18:30   ` Kris Warkentin
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Jacobowitz @ 2003-06-17 18:17 UTC (permalink / raw)
  To: Kris Warkentin; +Cc: Gdb-Patches@Sources.Redhat.Com

On Tue, Jun 17, 2003 at 01:58:18PM -0400, Kris Warkentin wrote:
> Since I'm braindead today....okay to commit?

Sure, but brush up on style:
> --- 97,104 ----
>         arch = "x86";
>         endian = "";
>       }
> !   else if (strcmp (TARGET_ARCHITECTURE->arch_name, "rs6000") == 0 ||
> !     strcmp (TARGET_ARCHITECTURE->arch_name, "powerpc") == 0)
>       {
>         arch = "ppc";
>         endian = "be";

|| goes at the beginning of the next line.

> --- 131,138 ----
>         arch = "x86";
>         endian = "";
>       }
> !   else if (strcmp (TARGET_ARCHITECTURE->arch_name, "rs6000") == 0 ||
> !     strcmp (TARGET_ARCHITECTURE->arch_name, "powerpc") == 0)
>       {
>         arch = "ppc";
>         endian = "be";

Likewise.

For the indentation changes, I'll just have to take your word for it -
they're so mangled by the time they get through your MUA that they're
useless.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ob?] nto-tdep.c: recognize powerpc as well as rs6000
  2003-06-17 18:17 ` Daniel Jacobowitz
@ 2003-06-17 18:30   ` Kris Warkentin
  2003-06-17 18:37     ` Daniel Jacobowitz
  0 siblings, 1 reply; 5+ messages in thread
From: Kris Warkentin @ 2003-06-17 18:30 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: Gdb-Patches@Sources.Redhat.Com

> Sure, but brush up on style:
>
> || goes at the beginning of the next line.

Okay.  I like that better.

> Likewise.
>
> For the indentation changes, I'll just have to take your word for it -
> they're so mangled by the time they get through your MUA that they're
> useless.

You guys keep beating around the bush....if you don't like Outlook, why
don't you just come out and say it?

;-)

I don't care for it much myself....that's why gdb_indent.sh is my friend.
Made those changes and committed.

cheers,

Kris



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ob?] nto-tdep.c: recognize powerpc as well as rs6000
  2003-06-17 18:30   ` Kris Warkentin
@ 2003-06-17 18:37     ` Daniel Jacobowitz
  2003-06-17 18:55       ` Kris Warkentin
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Jacobowitz @ 2003-06-17 18:37 UTC (permalink / raw)
  To: Kris Warkentin; +Cc: Gdb-Patches@Sources.Redhat.Com

On Tue, Jun 17, 2003 at 02:31:03PM -0400, Kris Warkentin wrote:
> > Sure, but brush up on style:
> >
> > || goes at the beginning of the next line.
> 
> Okay.  I like that better.
> 
> > Likewise.
> >
> > For the indentation changes, I'll just have to take your word for it -
> > they're so mangled by the time they get through your MUA that they're
> > useless.
> 
> You guys keep beating around the bush....if you don't like Outlook, why
> don't you just come out and say it?
> 
> ;-)

I've said it plenty of times.  I don't care what you use, though, as
long as it doesn't mangle your patches.  Can it do "Content-Disposition:
inline" attachments?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ob?] nto-tdep.c: recognize powerpc as well as rs6000
  2003-06-17 18:37     ` Daniel Jacobowitz
@ 2003-06-17 18:55       ` Kris Warkentin
  0 siblings, 0 replies; 5+ messages in thread
From: Kris Warkentin @ 2003-06-17 18:55 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: Gdb-Patches@Sources.Redhat.Com

> I've said it plenty of times.  I don't care what you use, though, as
> long as it doesn't mangle your patches.  Can it do "Content-Disposition:
> inline" attachments?

Dunno.  It's Outlook.  I don't expect it to be able to do anything sensible.
I'm downloading pine right now - I'll use that for submitting patches in the
future.  Always liked pine, I did.  Back in the day when I used to use Unix
OSes...mumble mumble....

cheers,

Kris



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2003-06-17 18:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-17 17:58 [ob?] nto-tdep.c: recognize powerpc as well as rs6000 Kris Warkentin
2003-06-17 18:17 ` Daniel Jacobowitz
2003-06-17 18:30   ` Kris Warkentin
2003-06-17 18:37     ` Daniel Jacobowitz
2003-06-17 18:55       ` Kris Warkentin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox