From: Daniel Jacobowitz <drow@mvista.com>
To: Kris Warkentin <kewarken@qnx.com>
Cc: "Gdb-Patches@Sources.Redhat.Com" <gdb-patches@sources.redhat.com>
Subject: Re: [ob?] nto-tdep.c: recognize powerpc as well as rs6000
Date: Tue, 17 Jun 2003 18:17:00 -0000 [thread overview]
Message-ID: <20030617181746.GA6669@nevyn.them.org> (raw)
In-Reply-To: <094501c334fa$08c62ea0$0202040a@catdog>
On Tue, Jun 17, 2003 at 01:58:18PM -0400, Kris Warkentin wrote:
> Since I'm braindead today....okay to commit?
Sure, but brush up on style:
> --- 97,104 ----
> arch = "x86";
> endian = "";
> }
> ! else if (strcmp (TARGET_ARCHITECTURE->arch_name, "rs6000") == 0 ||
> ! strcmp (TARGET_ARCHITECTURE->arch_name, "powerpc") == 0)
> {
> arch = "ppc";
> endian = "be";
|| goes at the beginning of the next line.
> --- 131,138 ----
> arch = "x86";
> endian = "";
> }
> ! else if (strcmp (TARGET_ARCHITECTURE->arch_name, "rs6000") == 0 ||
> ! strcmp (TARGET_ARCHITECTURE->arch_name, "powerpc") == 0)
> {
> arch = "ppc";
> endian = "be";
Likewise.
For the indentation changes, I'll just have to take your word for it -
they're so mangled by the time they get through your MUA that they're
useless.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-06-17 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-17 17:58 Kris Warkentin
2003-06-17 18:17 ` Daniel Jacobowitz [this message]
2003-06-17 18:30 ` Kris Warkentin
2003-06-17 18:37 ` Daniel Jacobowitz
2003-06-17 18:55 ` Kris Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030617181746.GA6669@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kewarken@qnx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox