Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 5/8] Remove C++ special case from process_imported_unit_die
Date: Wed, 8 Apr 2026 13:17:16 +0200	[thread overview]
Message-ID: <082dc7d8-31a9-4f67-b558-ba8fcab673cb@suse.de> (raw)
In-Reply-To: <871pgqy51b.fsf@tromey.com>

On 4/7/26 8:54 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
>>> Instead, because (1) this is weird and rare DWARF anyway, and (2) this
>>> is just a performance optimization, I propose removing this.
> 
> Tom> I agree removing it is the right thing to do.
> 
> Tom> I also feels weird to me, though the DWARF standard explicitly allows it.
> 
> Tom> But from the perspective of a linux distro using gcc and lto for
> Tom> package compilation, it's the opposite of rare.
> 
> Tom> Anyway, I've filed a PR to reimplement this in some form or another (
> Tom> https://sourceware.org/bugzilla/show_bug.cgi?id=33922 ).
> 
> Thanks for filing that.
> 
> I think the patch you posted there seems promising.  I wonder if it
> could help with another case of over-eager CU expansion.

I haven't looked at the other PR, but I posted an RFC documenting the 
current state of the patch.

Thanks,
- Tom

  reply	other threads:[~2026-04-08 11:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  1:16 [PATCH v4 0/8] Correctly handle inline functions with dwz Tom Tromey
2026-02-24  1:16 ` [PATCH v4 1/8] Don't call add_dependence from index_imported_unit Tom Tromey
2026-02-24  1:16 ` [PATCH v4 2/8] Skip partial units in process_psymtab_comp_unit Tom Tromey
2026-02-24  1:16 ` [PATCH v4 3/8] Don't consider DW_TAG_inlined_subroutine as interesting Tom Tromey
2026-02-24  1:16 ` [PATCH v4 4/8] Combine two cases in cooked_index_functions::search Tom Tromey
2026-02-24  1:16 ` [PATCH v4 5/8] Remove C++ special case from process_imported_unit_die Tom Tromey
2026-02-24  9:18   ` Tom de Vries
2026-04-07 18:54     ` Tom Tromey
2026-04-08 11:17       ` Tom de Vries [this message]
2026-02-24  1:16 ` [PATCH v4 6/8] Have iterate_over_one_compunit_symtab search included symtabs Tom Tromey
2026-02-24  1:17 ` [PATCH v4 7/8] Handle inline functions with dwz Tom Tromey
2026-02-24  1:17 ` [PATCH v4 8/8] Update .debug_names documentation Tom Tromey
2026-02-24  9:46 ` [PATCH v4 0/8] Correctly handle inline functions with dwz Tom de Vries
2026-04-07 19:10 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=082dc7d8-31a9-4f67-b558-ba8fcab673cb@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox