From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9H59I1g51mkgWw0AWB0awg (envelope-from ) for ; Wed, 08 Apr 2026 07:17:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VxB1T/FE; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=95VRzn1u; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VxB1T/FE; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=95VRzn1u; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7C9E01E0BC; Wed, 08 Apr 2026 07:17:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB8C21E04F for ; Wed, 08 Apr 2026 07:17:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 67D974BA2E17 for ; Wed, 8 Apr 2026 11:17:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67D974BA2E17 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VxB1T/FE; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=95VRzn1u; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VxB1T/FE; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=95VRzn1u Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 5A5BA4BA2E04 for ; Wed, 8 Apr 2026 11:17:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5A5BA4BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5A5BA4BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775647038; cv=none; b=lw7d4GkkBhOCnrKfCNYM+aaO/OobU7PCgLjuR14hayl0gyc2qnH+rmZt56Ovfi/8WO+Pyq/rSa2DBN/8agSA5JL/Fk2LHHyCQi+5vV9zhOGBv3AkntTgga7MTg06WKVufACjOK1oKCdBANYKTTta8lJy+RpztXkXGBFEOf4EVsA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775647038; c=relaxed/simple; bh=CdIPe3U/jHE8BBYLr9dcVjFJPGayq/KM99LRYDMk5Qc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=ph7BZeSZSfg0XKrQv5wcZ70n4aYfPcYp8j9cQtLyAUIBMZZJvMWdjYIP/p5x6kD5q2RJ30aaL5kloYSB8s2e+y0Qy1qEP/dUEflUGMFmaZRBYN4ciVWIk5ITYRuaEj2zzgky/5sl317d4UN7kTZ+cB0KaDMpUeBtxmuiepWBUnY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A5BA4BA2E04 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 423B84E987; Wed, 8 Apr 2026 11:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775647037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hUTQtCv5gfMVhaY2pxxmlgj5hKeiZuYkkqRE0cdI68=; b=VxB1T/FEPsmFNe1Ddaq30s6CjgWbbPXaOeo6JlD96NmunPYXA1nM6FHsrBYZ6gU9qWL9FF cr9tIxjkZGYb4/W/Fvwxw5Yqr/nYnG/eGeRC2C0ZHqlFhu2l62e/BLEYoqpLVN1Z9Yo5gn QCfx0qWqaukkyXD+k63hdCc2TD+J5Zc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775647037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hUTQtCv5gfMVhaY2pxxmlgj5hKeiZuYkkqRE0cdI68=; b=95VRzn1uAJhUqSvP9avABN+RMAlFlOa3x6wLsUcgF1VND3wiUl32Z8WR1wwcEJb7pA8jJN qn8U1dU66cZkwUCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775647037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hUTQtCv5gfMVhaY2pxxmlgj5hKeiZuYkkqRE0cdI68=; b=VxB1T/FEPsmFNe1Ddaq30s6CjgWbbPXaOeo6JlD96NmunPYXA1nM6FHsrBYZ6gU9qWL9FF cr9tIxjkZGYb4/W/Fvwxw5Yqr/nYnG/eGeRC2C0ZHqlFhu2l62e/BLEYoqpLVN1Z9Yo5gn QCfx0qWqaukkyXD+k63hdCc2TD+J5Zc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775647037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hUTQtCv5gfMVhaY2pxxmlgj5hKeiZuYkkqRE0cdI68=; b=95VRzn1uAJhUqSvP9avABN+RMAlFlOa3x6wLsUcgF1VND3wiUl32Z8WR1wwcEJb7pA8jJN qn8U1dU66cZkwUCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2B1514A0B3; Wed, 8 Apr 2026 11:17:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6gclCT051mnjIAAAD6G6ig (envelope-from ); Wed, 08 Apr 2026 11:17:17 +0000 Message-ID: <082dc7d8-31a9-4f67-b558-ba8fcab673cb@suse.de> Date: Wed, 8 Apr 2026 13:17:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/8] Remove C++ special case from process_imported_unit_die To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-0-bf923dc5fb19@tromey.com> <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-5-bf923dc5fb19@tromey.com> <871pgqy51b.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <871pgqy51b.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email, sourceware.org:url] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/7/26 8:54 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > >>> Instead, because (1) this is weird and rare DWARF anyway, and (2) this >>> is just a performance optimization, I propose removing this. > > Tom> I agree removing it is the right thing to do. > > Tom> I also feels weird to me, though the DWARF standard explicitly allows it. > > Tom> But from the perspective of a linux distro using gcc and lto for > Tom> package compilation, it's the opposite of rare. > > Tom> Anyway, I've filed a PR to reimplement this in some form or another ( > Tom> https://sourceware.org/bugzilla/show_bug.cgi?id=33922 ). > > Thanks for filing that. > > I think the patch you posted there seems promising. I wonder if it > could help with another case of over-eager CU expansion. I haven't looked at the other PR, but I posted an RFC documenting the current state of the patch. Thanks, - Tom