Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 0/8] Correctly handle inline functions with dwz
Date: Tue, 07 Apr 2026 13:10:58 -0600	[thread overview]
Message-ID: <87wlyiwpq5.fsf@tromey.com> (raw)
In-Reply-To: <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-0-bf923dc5fb19@tromey.com> (Tom Tromey's message of "Mon, 23 Feb 2026 18:16:53 -0700")

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> The new indexer does not correctly handle inline functions when 'dwz'
Tom> is used to compress the DWARF.  This series fixes the bug, cleaning up
Tom> a number of other things on the way.

Tom> I've separately regression tested each patch in this series on x86-64
Tom> Fedora 41.  I've also regression tested the series as a whole with the
Tom> dwz, gdb-index, and debug-names boards.

Tom> Even with that I messed up somehow, so v1 didn't actually fix the bug
Tom> in question.  I must have modified the patches after testing..?

Tom> Anyway in v2 I've moved the line recording the CU inclusion and added
Tom> a comment explaining the placement.  I re-ran the aformentioned tests
Tom> and didn't touch anything.

I'm going to check this in now.

Tom

      parent reply	other threads:[~2026-04-07 19:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  1:16 Tom Tromey
2026-02-24  1:16 ` [PATCH v4 1/8] Don't call add_dependence from index_imported_unit Tom Tromey
2026-02-24  1:16 ` [PATCH v4 2/8] Skip partial units in process_psymtab_comp_unit Tom Tromey
2026-02-24  1:16 ` [PATCH v4 3/8] Don't consider DW_TAG_inlined_subroutine as interesting Tom Tromey
2026-02-24  1:16 ` [PATCH v4 4/8] Combine two cases in cooked_index_functions::search Tom Tromey
2026-02-24  1:16 ` [PATCH v4 5/8] Remove C++ special case from process_imported_unit_die Tom Tromey
2026-02-24  9:18   ` Tom de Vries
2026-04-07 18:54     ` Tom Tromey
2026-04-08 11:17       ` Tom de Vries
2026-02-24  1:16 ` [PATCH v4 6/8] Have iterate_over_one_compunit_symtab search included symtabs Tom Tromey
2026-02-24  1:17 ` [PATCH v4 7/8] Handle inline functions with dwz Tom Tromey
2026-02-24  1:17 ` [PATCH v4 8/8] Update .debug_names documentation Tom Tromey
2026-02-24  9:46 ` [PATCH v4 0/8] Correctly handle inline functions with dwz Tom de Vries
2026-04-07 19:10 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wlyiwpq5.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox