Re: [PATCH] gdb.rocm: Don't include unistd.h when not necessary

[Lancelot SIX <Lancelot.Six@amd.com>]

On 02/07/2026 13:23, Pedro Alves wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> gdb.rocm/code-object-load-while-breakpoint-hit.cpp is including
> unistd.h unnecessarily AFAICS.  Don't include it, so this test can
> compile on Windows (x86_64-pc-windows-msvc) as well.
> 
> Change-Id: I9f469fd4b061ab9895c8bbbd408939e4df2a4e92

Good catch, this looks good to me.

Approve-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)

Best,
Lancelot.

> ---
>   gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp
> index d2f2ddcbf6c..d7101b419c0 100644
> --- a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp
> +++ b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp
> @@ -36,7 +36,6 @@ kernel ()
>   #else
> 
>   #include <hip/hip_runtime.h>
> -#include <unistd.h>
> 
>   #include "rocm-test-utils.h"
> 
> 
> base-commit: 18ca02157d9cc245f035452e397a07a3787034d0
> --
> 2.54.0
>