From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oid8AOmTR2o9lCMAWB0awg (envelope-from ) for ; Fri, 03 Jul 2026 06:50:17 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Eqbu+ng6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E56EC1E098; Fri, 03 Jul 2026 06:50:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 721AA1E024 for ; Fri, 03 Jul 2026 06:50:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 082E44BA798D for ; Fri, 3 Jul 2026 10:50:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 082E44BA798D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Eqbu+ng6 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011031.outbound.protection.outlook.com [52.101.62.31]) by sourceware.org (Postfix) with ESMTPS id 67A624BA2E26 for ; Fri, 3 Jul 2026 10:49:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67A624BA2E26 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 67A624BA2E26 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.62.31 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783075789; cv=pass; b=D4op6VUxPE8Jtf1a5+UDheOzuFRSAyOCvo/gRqq0tWEP8Rg7nkx4ceaPG8OF84wbNBnrthNZq8Ob1D3slgpCoGt0zrq4O8hGSLu5/CdbhJ90hp06fLk3aNpjhe9urrQqoHue8BtbuFsZGjShifnrd99GV+A0pAJY7PScxgkJ8uo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783075789; c=relaxed/simple; bh=tf9aRmcNn4Lqv9/KMmpr704KqZbSCSLvMLD/eZQvAzw=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=ETkWwuAH6hrnoErzIsO1/FcW2sAC9PwgBBLKm3YA/PE5VYCmklDGcwVCzA2YdWt6tRpHv2x3o2cjixqO8w/JfcYjR94jolC5ZBdEDeMz3OHMuT/vdhLytjiTo9VDnpHub9piqGtjrlnfHRzBD6qTveJgcXCeuc5zXLFvnMi44As= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Eqbu+ng6 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67A624BA2E26 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CdfG28bNOH1vQ3JEvn4P/FxCtKpU2dZLYBgsde91/Q5mPegYbujIYUaOi060FZgcY0Tc5AR7Dx92mbiMcYFh604RoHGaOQ4mUZ6m9HCHyVy50E2fkhh3DZkYmXfZGum6GieMtrknYvBOhPycAiOu0irka+/sgyWHADISZcNR4etfMHMhMknlebULC32+RxweZAJ+ovUafjHaA607S937iStS8o5LkOOP5LUaWhB27zebJbUnyIGbDKPo5GpTKz40+wl4Q8octLERUimylus7kE5tJvXPrzpFYqZzuC5QqesDmFkYHvfw3jfBA0/Z17M/QWg+yLAt+KfeOtPjIdxHfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3FwVB+lMyoxgNuHFaAtVx5tkZgI8zRCOwK4Zemov9Mw=; b=Q7jq1f/CkU7OL2MoIBszjwz3N/iqprxkP1PzWOs1QP0g1gsGweMB6MdZrdZFC/7gT1QqS0zuPMMUOh1SX2D5tifovtu/Le6wbT3sMiSNBXxKHpyOuJPy7MwiTiK4ghvelNHbDKZdbD08QxEpuMZ4dffbjsq0Afd3f+WJ+JSbF71NGtUl7J7vUqxVGCiqg3lbylEq812Txzjmg+HlifxNRXR3ZJCwWEYWjI/ipNCZn4Fruet8Y8bRYu8j09Pe68TYqqbgj50i8vK5ZDR96QVGd6ugIoNyHvn0WQto29tahAb3vbTlmBdba11N/gXvUiz6kieNjJOhrVy8MxP0otnZVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FwVB+lMyoxgNuHFaAtVx5tkZgI8zRCOwK4Zemov9Mw=; b=Eqbu+ng6qrAdNnK0UTfWZNFmH9YDUOp/EAzs7XE6UdgDxmkfwWDYZomd6LtNFM/8A6PPMCWc9LVQzmWz/FtyuyMN+tuiWfS79neB8ExapCSFCFxkpFlJiZ9by86kD8t0hxcOS7cxGuUu7a5No0dOmOMgchSCVfzMmrAMKjPYZw0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by DM4PR12MB6496.namprd12.prod.outlook.com (2603:10b6:8:bd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Fri, 3 Jul 2026 10:49:41 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3%5]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 10:49:41 +0000 Message-ID: <02483ec7-713d-472f-a5e8-0e49e4b85dc5@amd.com> Date: Fri, 3 Jul 2026 11:49:36 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb.rocm: Don't include unistd.h when not necessary To: Pedro Alves , gdb-patches@sourceware.org References: <20260702122325.330129-1-pedro@palves.net> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20260702122325.330129-1-pedro@palves.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::16) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|DM4PR12MB6496:EE_ X-MS-Office365-Filtering-Correlation-Id: 53ca5d56-49c1-4739-cbd3-08ded8f0c941 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|22082099003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: XYcI/Q2N7SNqbz9zUYRDbMZgW+tfycSzy7ne2+XydsE9X+/vlp1AC47GHHJKJQNUI16RgkiKSeIiZbgg2FlS5eXrCNb9XQBFNsbCuWLkxj9E25DRX9HmFmIOL0l15mz1gEOXRKweWuKlriAwroEyjaa0HF1V+jincsDYOcFLod77itPWNowqo4bLUOZ5UbDzXFfI3vX1s/KnelJ7Y47HBNWIZ5/XkXFyNaUCW3FSrn7PztvfCCqQ3pbIYYJo/bO2KerKilPKtrrbEC8ZiG4Xxo8IAAJqn1neAo4pZszkgMn2dgzECbFnjeJQqSsPoIKpsKAnveGVOGKHIblysGZiooUXInLedKCkGrzg1TUy8aLkDo6R2OoEAPe3qH+ij4wfUOHWZwLAw8AEuuJszrmyhh4w4IVFluODWjGPeUqTGAOc//G7VL/oerL4mcsvEg5e0vQNOPZLkGcNMVOkrvEdCPQyEuQCK49PYDg0ziU/9NMU6L4AcJw9nzpTu8qvOo5V3VzZYGr/zWUU2vk7/axFh6/YKQQGnbtmX4QCQIMwjKdbMlp//82MWVocuJaxomKRJdNej8hisj7r5lYOLMvHjCclafn8RN9rGqs0oV6p3r1vZd/nEEE173PxcheFZR2f X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(18002099003)(56012099006)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWR6MjJWamFDS0hLbXBCTjRsSk94alpjY2loOEMvN2tnT1h0M1BoY3g2MXIy?= =?utf-8?B?M2I4eUpBNmM0MFdQWGx6VWpnWFdRbHp5L0RQM2JCZ1B0U1g4azJNRmRPM2xW?= =?utf-8?B?bzFnV3p6Y1Q1MXZUMnBNc0xIUHlGV3psZFFiczVBU2JQQTgvb2JCa2hTNHpC?= =?utf-8?B?bTAxQ01DU2dRNEZPTmIwWDJmSnVGV0xxU1UyQzZVU3JTR2orbk9WNGdobENB?= =?utf-8?B?WXZKcEFyMFZQd2owQUZNcXEwVDJrZjZtQ2lWYWlTeXdrcndOZThCOXhVSExh?= =?utf-8?B?QTlvZWRHZVhTZTlJT05WdGZkaHliN21iS1pSOHBqVjlZRFNodWJHN2syN0M5?= =?utf-8?B?TGhTVWpCZ3hQSVhqMkwvZkhoSUg4aGFqeWRuSTNsejEvNGxFTFF2dlBQQklU?= =?utf-8?B?Si9ZQmtDZ2ZRMVgwRGVOdlJ6M3M2RDlwTzF4czBUT1E5cWhJTjlFWTMzZUZN?= =?utf-8?B?QSswZVNtby8wdmdia0F4Ulk1SHZQRmo3ZzBsZzgxSUVpYWtKaWl4a1NhcWQr?= =?utf-8?B?S3BnSHdZaCtkZXZlQjhTSEw1RDVBR1ZqS0FoRzlMZXRtcHl0VTU5OFpVRXJp?= =?utf-8?B?UE4xTVdwTzRVTzZydWRKUmkyWGRHMGVqbjJYZ2NsczJpVzAvTWNzaVozRFhJ?= =?utf-8?B?Rm1Jb292STNHMXNKK2p4ejRiK1ZrOE1Lc1FGb2lTUHk0empQVkpxWVVJa2E5?= =?utf-8?B?S0RuajVXcVBzRXdBbnJIeHo4NGppUHBlZDhuRUJuUVhWVWVtRnJXYjJJM2k1?= =?utf-8?B?eDJQWXpCVXdWdVgvK1BRZlRsc3k4aTJiYitJcUwwK1N4N0tyQWlKWm5lcW91?= =?utf-8?B?eG00Rm1SVTNKa2FyQytYdkIyb055d0VHcnV6N2hYTm9uWmhxZTdBRVlSckRp?= =?utf-8?B?ODBXbzFEZHVzSGtWa1c3c05sbzFNbW5qSjRWa0NPV09JYWluaVI5UHRXWmdF?= =?utf-8?B?eXB6Szd6SGZqTk54WkdZdEVFOHNIODl0TlRKQUVUMkMvd29iTEwwTDJFME5o?= =?utf-8?B?VnU4UmYvMnN4cTBUbjR2V3JLYUw5UnVoSHFMZDh3U0xoaWE3UnJVK1p5NHIz?= =?utf-8?B?TEJoMGM1TE9vcEduc085b05Cc0FkbWsyMnEvWUFwRElkcFg3R29iWmlTMXJN?= =?utf-8?B?SjErMno4M0d0Z2kwY2dFc2dmTkdVbEp6bjYxNzZyeDlQM3VrbW5aRmlKWWNZ?= =?utf-8?B?NFQ4TnlUSjRKandXajhNL3ZwOWZWU2hOMk52OWtNdEsrY0pBbnQxd1ZXdGti?= =?utf-8?B?TGhBeEQyYk91L3NPa2R1U0oxdGVRV3BWTDlZcVJQRFZla1hxYldWSytqRFVn?= =?utf-8?B?TkxLTXZyTUZLV2V4bmVRcnMyVFJMdHdVN0dnMkRqU2R5cW9RZzhEZXBtYUZK?= =?utf-8?B?UlRQMDFKcnl2ZzhUaWsyczk4NzV6Y3d2bUJLOXlEak4yZGpFQklRVEI5cGcy?= =?utf-8?B?YXphVmQyOWtWRk0vNjV1NTdSS2Y3MVZMV0ZHbjZkOFdxbUg4d0ZaVVJQWDRU?= =?utf-8?B?WDFObnNIM3ZHMFZ1LytrSkxOeGNtNW9nYVZrbE1qUzRYODVhN2pNc1ovYlZ5?= =?utf-8?B?TUU3REZFTnF6WmFMNWo5OENVd0wyWnVCSXRyYjAzNy9EWFhDdXN3TzU4akhy?= =?utf-8?B?QVpWNHNxM0x5bEtGMW56TkFNOWdtamUvY2ZxNmJPQXFwbFZZYnVkREVoSk5J?= =?utf-8?B?K2ZHRE8wWmY0N01SaDVwOVpEWnR1R01OWGlOTFdhVm9ZM1NYRG0vVzh2ZjRN?= =?utf-8?B?ZGJleDM2OGU2TFJOVE9zaHBiYUhETDc4OVlOcG5LM3JzL09rZStmWUJVcjcr?= =?utf-8?B?SS8zenpzU1NtTjR0a2hPNFJ3d1VxK3UxeGxQclZMVWFTQTlITnhvRFFUTFNK?= =?utf-8?B?UzU0YlpUS1dBRDZQekV5L0xjcVk5bytBSkorTzc1SHhHWnJvVmZiVTMxY1Mw?= =?utf-8?B?aWRBVEFPY2gxTXV4dWpLcEE4b0JyUjQrNWhMNm1VbjJkd1d6d1MvckExM09x?= =?utf-8?B?Q2JERWhSZndKQ2pTU1VuREJVcVJvZEJ0c1F6dWNkdGN2SGhUUnBmeXNXdWhR?= =?utf-8?B?dFpNbFc5dm0rMUZuSU10dHYvUGJLZTliUnEra295MkpPM0Z5Skswc2NXR2sw?= =?utf-8?B?elYzb2FtWEwyOUFFTDU5SUxsbEozQWJJSndSUHBrdFZ5eVBjU3d2cGhFMUc5?= =?utf-8?B?eGFoUUl2T0VwRU1semJ6a3ZMc0l5ZnhjU1NBdHMwVnJsR2QwUFlZaTF4WE1T?= =?utf-8?B?cm5hckxTTVhaWWhscjB3SEdXYmRHZGpxUU01dmswUXBEcVlaek83cmd6SmhP?= =?utf-8?Q?THpDMxj3t8vS6Zq2Sm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53ca5d56-49c1-4739-cbd3-08ded8f0c941 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 10:49:41.6462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dWoDYarENfQTUeU7KzW3Y2Fy10eInpTFgaPH6U7sNFexMSpSR7tLqV/L5NYQyqjlA0LrAIcbHBNRGNHhW+lRFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6496 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 02/07/2026 13:23, Pedro Alves wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > gdb.rocm/code-object-load-while-breakpoint-hit.cpp is including > unistd.h unnecessarily AFAICS. Don't include it, so this test can > compile on Windows (x86_64-pc-windows-msvc) as well. > > Change-Id: I9f469fd4b061ab9895c8bbbd408939e4df2a4e92 Good catch, this looks good to me. Approve-by: Lancelot Six (amdgpu) Best, Lancelot. > --- > gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp > index d2f2ddcbf6c..d7101b419c0 100644 > --- a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp > +++ b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp > @@ -36,7 +36,6 @@ kernel () > #else > > #include > -#include > > #include "rocm-test-utils.h" > > > base-commit: 18ca02157d9cc245f035452e397a07a3787034d0 > -- > 2.54.0 >