From: Pedro Alves <pedro@palves.net>
To: gdb-patches@sourceware.org
Cc: Lancelot SIX <lancelot.six@amd.com>
Subject: [PATCH] gdb.rocm: Don't include unistd.h when not necessary
Date: Thu, 2 Jul 2026 13:23:25 +0100 [thread overview]
Message-ID: <20260702122325.330129-1-pedro@palves.net> (raw)
gdb.rocm/code-object-load-while-breakpoint-hit.cpp is including
unistd.h unnecessarily AFAICS. Don't include it, so this test can
compile on Windows (x86_64-pc-windows-msvc) as well.
Change-Id: I9f469fd4b061ab9895c8bbbd408939e4df2a4e92
---
gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp
index d2f2ddcbf6c..d7101b419c0 100644
--- a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp
+++ b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp
@@ -36,7 +36,6 @@ kernel ()
#else
#include <hip/hip_runtime.h>
-#include <unistd.h>
#include "rocm-test-utils.h"
base-commit: 18ca02157d9cc245f035452e397a07a3787034d0
--
2.54.0
next reply other threads:[~2026-07-02 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 12:23 Pedro Alves [this message]
2026-07-03 10:49 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702122325.330129-1-pedro@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox