[Fwd: Re: MinGW patch for readline?]

[Fwd: Re: MinGW patch for readline?]

[Mark Mitchell]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

Given this message from Chet, is it OK to check in the MinGW readline 
patch I posted previously?

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

[-- Attachment #2: Re: MinGW patch for readline? --]
[-- Type: message/rfc822, Size: 2711 bytes --]

From: Chet Ramey <chet.ramey@case.edu>
To: Mark Mitchell <mark@codesourcery.com>
Cc: chet@case.edu
Subject: Re: MinGW patch for readline?
Date: Fri, 06 May 2005 19:54:50 -0400
Message-ID: <427C03CA.9050506@case.edu>

Mark Mitchell wrote:
> Chet --
> 
> Last week, I posted a patch to add autoconf tests to readline, in
> support of compilation under MinGW.  I believe that the GDB maintainers
> are waiting for official inclusion in readline before accepting the
> patch for GDB.  You seemed to look favorably on the patch, but I think
> you wanted to do some additional review.  Is there anything I can do to
> help with that?

I simply wanted to look at it.  I have done so; it's all good.  The
changes will appear in the next release of readline, though there may
be some minor changes.

If the gdb maintainers want assurance that these patches will appear in
a future version of readline, feel free to forward this message to them.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
( ``Discere est Dolere'' -- chet )
						Live...Laugh...Love
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/

Re: [Fwd: Re: MinGW patch for readline?]

[Eli Zaretskii]

> Date: Fri, 06 May 2005 18:11:53 -0700
> From: Mark Mitchell <mark@codesourcery.com>
> 
> Given this message from Chet, is it OK to check in the MinGW readline 
> patch I posted previously?

I'm not sure who should approve this, since Elena is still listed as a
responsible maintainer for readline.  If global maintainers can give
an approval, you have mine.

Re: [Fwd: Re: MinGW patch for readline?]

[Christopher Faylor]

On Sat, May 07, 2005 at 01:09:10PM +0300, Eli Zaretskii wrote:
>> Date: Fri, 06 May 2005 18:11:53 -0700
>> From: Mark Mitchell <mark@codesourcery.com>
>> 
>> Given this message from Chet, is it OK to check in the MinGW readline 
>> patch I posted previously?
>
>I'm not sure who should approve this, since Elena is still listed as a
>responsible maintainer for readline.  If global maintainers can give
>an approval, you have mine.

And if windows maintainers can give approval, you have mine.

cgf

Re: [Fwd: Re: MinGW patch for readline?]

[Mark Mitchell]

Christopher Faylor wrote:
> On Sat, May 07, 2005 at 01:09:10PM +0300, Eli Zaretskii wrote:
> 
>>>Date: Fri, 06 May 2005 18:11:53 -0700
>>>From: Mark Mitchell <mark@codesourcery.com>
>>>
>>>Given this message from Chet, is it OK to check in the MinGW readline 
>>>patch I posted previously?
>>
>>I'm not sure who should approve this, since Elena is still listed as a
>>responsible maintainer for readline.  If global maintainers can give
>>an approval, you have mine.
> 
> 
> And if windows maintainers can give approval, you have mine.

Eli, Chris --

Now, I just need someone to approve your approvals, I guess. :-)

Thanks for the thumbs-ups.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Re: [Fwd: Re: MinGW patch for readline?]

[Daniel Jacobowitz]

On Sun, May 08, 2005 at 04:59:28PM -0700, Mark Mitchell wrote:
> Christopher Faylor wrote:
> >On Sat, May 07, 2005 at 01:09:10PM +0300, Eli Zaretskii wrote:
> >
> >>>Date: Fri, 06 May 2005 18:11:53 -0700
> >>>From: Mark Mitchell <mark@codesourcery.com>
> >>>
> >>>Given this message from Chet, is it OK to check in the MinGW readline 
> >>>patch I posted previously?
> >>
> >>I'm not sure who should approve this, since Elena is still listed as a
> >>responsible maintainer for readline.  If global maintainers can give
> >>an approval, you have mine.
> >
> >
> >And if windows maintainers can give approval, you have mine.
> 
> Eli, Chris --
> 
> Now, I just need someone to approve your approvals, I guess. :-)
> 
> Thanks for the thumbs-ups.

Have you asked Elena directly - presumably the polite thing to do since
she is listed as the maintainer for the in-tree copy of readline?

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [Fwd: Re: MinGW patch for readline?]

[Mark Mitchell]

Daniel Jacobowitz wrote:

> Have you asked Elena directly - presumably the polite thing to do since
> she is listed as the maintainer for the in-tree copy of readline?

I assumed she was reading this list, but I will send her a direct email.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Re: [Fwd: Re: MinGW patch for readline?]

[Daniel Jacobowitz]

On Sun, May 08, 2005 at 05:59:20PM -0700, Mark Mitchell wrote:
> Daniel Jacobowitz wrote:
> 
> >Have you asked Elena directly - presumably the polite thing to do since
> >she is listed as the maintainer for the in-tree copy of readline?
> 
> I assumed she was reading this list, but I will send her a direct email.

Since Eli has already asked Elena to look at it, and she hasn't
objected, let's go with this bit:
                        Host maintainers (host dependant parts)
                        (but get your changes into the master version)

The changes will be in the next readline release; so they're OK for our
copy.  Make sure to put the changelog entry in readline/ChangeLog.gdb.
Are we done with Windows host patches now?

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [Fwd: Re: MinGW patch for readline?]

[Mark Mitchell]

Daniel Jacobowitz wrote:
> On Sun, May 08, 2005 at 05:59:20PM -0700, Mark Mitchell wrote:
> 
>>Daniel Jacobowitz wrote:
>>
>>
>>>Have you asked Elena directly - presumably the polite thing to do since
>>>she is listed as the maintainer for the in-tree copy of readline?
>>
>>I assumed she was reading this list, but I will send her a direct email.
> 
> 
> Since Eli has already asked Elena to look at it, and she hasn't
> objected, let's go with this bit:
>                         Host maintainers (host dependant parts)
>                         (but get your changes into the master version)
> 
> The changes will be in the next readline release; so they're OK for our
> copy.  Make sure to put the changelog entry in readline/ChangeLog.gdb.

Done, thanks!

> Are we done with Windows host patches now?

Not quite: I have two other, unreleated, readline patches.

But we're very close!

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Re: [Fwd: Re: MinGW patch for readline?]

[Elena Zannoni]

Please fix your ChangeLog.gdb entry to not say readline/<file>, but
instead <file> only.


Mark Mitchell writes:
 > Daniel Jacobowitz wrote:
 > > On Sun, May 08, 2005 at 05:59:20PM -0700, Mark Mitchell wrote:
 > > 
 > >>Daniel Jacobowitz wrote:
 > >>
 > >>
 > >>>Have you asked Elena directly - presumably the polite thing to do since
 > >>>she is listed as the maintainer for the in-tree copy of readline?
 > >>
 > >>I assumed she was reading this list, but I will send her a direct email.
 > > 
 > > 
 > > Since Eli has already asked Elena to look at it, and she hasn't
 > > objected, let's go with this bit:
 > >                         Host maintainers (host dependant parts)
 > >                         (but get your changes into the master version)
 > > 
 > > The changes will be in the next readline release; so they're OK for our
 > > copy.  Make sure to put the changelog entry in readline/ChangeLog.gdb.
 > 
 > Done, thanks!
 > 
 > > Are we done with Windows host patches now?
 > 
 > Not quite: I have two other, unreleated, readline patches.
 > 
 > But we're very close!
 > 
 > -- 
 > Mark Mitchell
 > CodeSourcery, LLC
 > mark@codesourcery.com
 > (916) 791-8304

Re: [Fwd: Re: MinGW patch for readline?]

[Mark Mitchell]

Elena Zannoni wrote:
> Please fix your ChangeLog.gdb entry to not say readline/<file>, but
> instead <file> only.

Done, thanks!

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Re: [Fwd: Re: MinGW patch for readline?]

[Eli Zaretskii]

> Date: Sun, 8 May 2005 20:57:06 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Christopher Faylor <me@cgf.cx>, gdb-patches@sources.redhat.com,
> 	Eli Zaretskii <eliz@gnu.org>
> 
> Have you asked Elena directly - presumably the polite thing to do since
> she is listed as the maintainer for the in-tree copy of readline?

I did that, when Mark posted his patch the first time.  My response
was addressed to Elena directly and asked for her approval.  See

   http://sourceware.org/ml/gdb-patches/2005-04/msg00419.html