From: "Eli Zaretskii" <eliz@gnu.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Add add_setshow_enum_cmd, use in mips
Date: Sat, 30 Oct 2004 23:24:00 -0000 [thread overview]
Message-ID: <01c4bed6$Blat.v2.2.2$fa231b20@zahav.net.il> (raw)
In-Reply-To: <4183BD22.3090905@gnu.org> (message from Andrew Cagney on Sat, 30 Oct 2004 12:11:14 -0400)
> Date: Sat, 30 Oct 2004 12:11:14 -0400
> From: Andrew Cagney <cagney@gnu.org>
>
> Another cleanup.
>
> committed,
FWIW, I don't see why is this a ``cleanup'', nor why should it be
committed without going through an RFA. You are introducing a new
function, so at the very least the reasons for its introduction should
have been explained and other maintainers should have been given an
opportunity to suggest alternative designs.
Sorry if this has been discussed in the past (but if so, a URL
pointing to those discussions should have been mentioned).
In any case, please add the documentation of this function to
gdbint.texinfo.
next prev parent reply other threads:[~2004-10-30 23:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 17:11 Andrew Cagney
2004-10-30 23:24 ` Eli Zaretskii [this message]
2004-10-31 23:01 ` Andrew Cagney
2004-11-01 4:47 ` Eli Zaretskii
2004-11-01 5:12 ` Daniel Jacobowitz
2004-11-01 21:15 ` Eli Zaretskii
2004-11-01 22:37 ` Daniel Jacobowitz
2004-11-02 4:51 ` Eli Zaretskii
2004-11-09 1:15 ` Daniel Jacobowitz
2004-11-09 5:00 ` Eli Zaretskii
2004-11-09 15:29 ` Andrew Cagney
2004-11-09 18:42 ` Daniel Jacobowitz
2004-11-10 4:33 ` Eli Zaretskii
2004-11-10 20:55 ` Eli Zaretskii
2004-11-10 21:42 ` Mark Kettenis
2004-11-10 23:31 ` Eli Zaretskii
2004-11-10 23:41 ` Daniel Jacobowitz
2004-11-11 0:00 ` Eli Zaretskii
2004-11-11 5:37 ` Daniel Jacobowitz
2004-11-11 5:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c4bed6$Blat.v2.2.2$fa231b20@zahav.net.il' \
--to=eliz@gnu.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox