From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10760 invoked by alias); 30 Oct 2004 23:24:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10753 invoked from network); 30 Oct 2004 23:24:14 -0000 Received: from unknown (HELO balder.inter.net.il) (192.114.186.15) by sourceware.org with SMTP; 30 Oct 2004 23:24:14 -0000 Received: from zaretski ([80.230.156.91]) by balder.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id DVO67138 (AUTH halo1); Sun, 31 Oct 2004 01:24:06 +0200 (IST) Date: Sat, 30 Oct 2004 23:24:00 -0000 From: "Eli Zaretskii" To: Andrew Cagney Message-ID: <01c4bed6$Blat.v2.2.2$fa231b20@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <4183BD22.3090905@gnu.org> (message from Andrew Cagney on Sat, 30 Oct 2004 12:11:14 -0400) Subject: Re: [commit] Add add_setshow_enum_cmd, use in mips Reply-to: Eli Zaretskii References: <4183BD22.3090905@gnu.org> X-SW-Source: 2004-10/txt/msg00524.txt.bz2 > Date: Sat, 30 Oct 2004 12:11:14 -0400 > From: Andrew Cagney > > Another cleanup. > > committed, FWIW, I don't see why is this a ``cleanup'', nor why should it be committed without going through an RFA. You are introducing a new function, so at the very least the reasons for its introduction should have been explained and other maintainers should have been given an opportunity to suggest alternative designs. Sorry if this has been discussed in the past (but if so, a URL pointing to those discussions should have been mentioned). In any case, please add the documentation of this function to gdbint.texinfo.