* [RFA] Remove cleanups from dbxread.c
@ 2018-05-25 16:07 Tom Tromey
2018-05-25 16:55 ` Pedro Alves
0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2018-05-25 16:07 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
This removes the remaining cleanups from dbxread.c, via std::vector,
scoped_restore, and unique_xmalloc_ptr.
Tested by the buildbot, but I'm not sure these code paths are actually
exercised there.
ChangeLog
2018-05-25 Tom Tromey <tom@tromey.com>
* dbxread.c (init_bincl_list): Remove.
(bincl_list): Now a std::vector.
(bincls_allocated, next_bincl): Remove.
(free_bincl_list, do_free_bincl_list_cleanup)
(make_cleanup_free_bincl_list): Remove.
(dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
unique_xmalloc_ptr.
(add_bincl_to_list, find_corresponding_bincl_psymtab)
(read_dbx_symtab): Update.
---
gdb/ChangeLog | 12 +++++++
gdb/dbxread.c | 108 ++++++++++++++++------------------------------------------
2 files changed, 41 insertions(+), 79 deletions(-)
diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 95b614cdae..830438c21e 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -243,8 +243,7 @@ struct header_file_location
};
/* The actual list and controling variables. */
-static struct header_file_location *bincl_list, *next_bincl;
-static int bincls_allocated;
+static std::vector<struct header_file_location> *bincl_list;
/* Local function prototypes. */
@@ -257,15 +256,11 @@ static void dbx_psymtab_to_symtab_1 (struct objfile *, struct partial_symtab *);
static void read_dbx_symtab (minimal_symbol_reader &, struct objfile *);
-static void free_bincl_list (struct objfile *);
-
static struct partial_symtab *find_corresponding_bincl_psymtab (const char *,
int);
static void add_bincl_to_list (struct partial_symtab *, const char *, int);
-static void init_bincl_list (int, struct objfile *);
-
static const char *dbx_next_symbol_text (struct objfile *);
static void fill_symbuf (bfd *);
@@ -855,35 +850,18 @@ dbx_next_symbol_text (struct objfile *objfile)
return nlist.n_strx + stringtab_global + file_string_table_offset;
}
\f
-/* Initialize the list of bincls to contain none and have some
- allocated. */
-
-static void
-init_bincl_list (int number, struct objfile *objfile)
-{
- bincls_allocated = number;
- next_bincl = bincl_list = XNEWVEC (struct header_file_location,
- bincls_allocated);
-}
/* Add a bincl to the list. */
static void
add_bincl_to_list (struct partial_symtab *pst, const char *name, int instance)
{
- if (next_bincl >= bincl_list + bincls_allocated)
- {
- int offset = next_bincl - bincl_list;
+ bincl_list->emplace_back ();
+ struct header_file_location *next_bincl = &bincl_list->back ();
- bincls_allocated *= 2;
- bincl_list = (struct header_file_location *)
- xrealloc ((char *) bincl_list,
- bincls_allocated * sizeof (struct header_file_location));
- next_bincl = bincl_list + offset;
- }
next_bincl->pst = pst;
next_bincl->instance = instance;
- next_bincl++->name = name;
+ next_bincl->name = name;
}
/* Given a name, value pair, find the corresponding
@@ -893,38 +871,15 @@ add_bincl_to_list (struct partial_symtab *pst, const char *name, int instance)
static struct partial_symtab *
find_corresponding_bincl_psymtab (const char *name, int instance)
{
- struct header_file_location *bincl;
-
- for (bincl = bincl_list; bincl < next_bincl; bincl++)
- if (bincl->instance == instance
- && strcmp (name, bincl->name) == 0)
- return bincl->pst;
+ for (struct header_file_location &bincl : *bincl_list)
+ if (bincl.instance == instance
+ && strcmp (name, bincl.name) == 0)
+ return bincl.pst;
repeated_header_complaint (name, symnum);
return (struct partial_symtab *) 0;
}
-/* Free the storage allocated for the bincl list. */
-
-static void
-free_bincl_list (struct objfile *objfile)
-{
- xfree (bincl_list);
- bincls_allocated = 0;
-}
-
-static void
-do_free_bincl_list_cleanup (void *objfile)
-{
- free_bincl_list ((struct objfile *) objfile);
-}
-
-static struct cleanup *
-make_cleanup_free_bincl_list (struct objfile *objfile)
-{
- return make_cleanup (do_free_bincl_list_cleanup, objfile);
-}
-
/* Set namestring based on nlist. If the string table index is invalid,
give a fake name, and print a single error message per symbol file read,
rather than abort the symbol reading or flood the user with messages. */
@@ -1019,7 +974,6 @@ read_dbx_symtab (minimal_symbol_reader &reader, struct objfile *objfile)
int nsl;
int past_first_source_file = 0;
CORE_ADDR last_function_start = 0;
- struct cleanup *back_to;
bfd *abfd;
int textlow_not_set;
int data_sect_index;
@@ -1060,8 +1014,9 @@ read_dbx_symtab (minimal_symbol_reader &reader, struct objfile *objfile)
sizeof (struct partial_symtab *));
/* Init bincl list */
- init_bincl_list (20, objfile);
- back_to = make_cleanup_free_bincl_list (objfile);
+ std::vector<struct header_file_location> bincl_storage;
+ scoped_restore restore_bincl_global
+ = make_scoped_restore (&bincl_list, &bincl_storage);
set_last_source_file (NULL);
@@ -1977,8 +1932,6 @@ read_dbx_symtab (minimal_symbol_reader &reader, struct objfile *objfile)
text_end > pst->texthigh ? text_end : pst->texthigh,
dependency_list, dependencies_used, textlow_not_set);
}
-
- do_cleanups (back_to);
}
/* Allocate and partially fill a partial symtab. It will be
@@ -2240,8 +2193,6 @@ dbx_read_symtab (struct partial_symtab *self, struct objfile *objfile)
if (LDSYMLEN (self) || self->number_of_dependencies)
{
- struct cleanup *back_to;
-
/* Print the message now, before reading the string table,
to avoid disconcerting pauses. */
if (info_verbose)
@@ -2252,22 +2203,20 @@ dbx_read_symtab (struct partial_symtab *self, struct objfile *objfile)
next_symbol_text_func = dbx_next_symbol_text;
- back_to = make_cleanup (null_cleanup, NULL);
-
- if (DBX_STAB_SECTION (objfile))
- {
- stabs_data
- = symfile_relocate_debug_section (objfile,
- DBX_STAB_SECTION (objfile),
- NULL);
-
- if (stabs_data)
- make_cleanup (free_current_contents, (void *) &stabs_data);
- }
-
- dbx_psymtab_to_symtab_1 (objfile, self);
+ {
+ scoped_restore restore_stabs_data = make_scoped_restore (&stabs_data);
+ gdb::unique_xmalloc_ptr<gdb_byte> data_holder;
+ if (DBX_STAB_SECTION (objfile))
+ {
+ stabs_data
+ = symfile_relocate_debug_section (objfile,
+ DBX_STAB_SECTION (objfile),
+ NULL);
+ data_holder.reset (stabs_data);
+ }
- do_cleanups (back_to);
+ dbx_psymtab_to_symtab_1 (objfile, self);
+ }
/* Match with global symbols. This only needs to be done once,
after all of the symtabs and dependencies have been read in. */
@@ -3146,7 +3095,6 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect,
int val;
bfd *sym_bfd = objfile->obfd;
char *name = bfd_get_filename (sym_bfd);
- struct cleanup *back_to = make_cleanup (null_cleanup, NULL);
/* Find the first and last text address. dbx_symfile_read seems to
want this. */
@@ -3184,9 +3132,13 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect,
symbuf_read = 0;
symbuf_left = bfd_section_size (objfile->obfd, stabsect);
+
+ scoped_restore restore_stabs_data = make_scoped_restore (&stabs_data);
+ gdb::unique_xmalloc_ptr<gdb_byte> data_holder;
+
stabs_data = symfile_relocate_debug_section (objfile, stabsect, NULL);
if (stabs_data)
- make_cleanup (free_current_contents, (void *) &stabs_data);
+ data_holder.reset (stabs_data);
/* In an elf file, we've already installed the minimal symbols that came
from the elf (non-stab) symbol table, so always act like an
@@ -3195,8 +3147,6 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect,
table and normal symbol entries won't be in the ".stab" section; but in
case it does, it will install them itself. */
dbx_symfile_read (objfile, 0);
-
- do_cleanups (back_to);
}
\f
/* Scan and build partial symbols for a file with special sections for stabs
--
2.13.6
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Remove cleanups from dbxread.c
2018-05-25 16:07 [RFA] Remove cleanups from dbxread.c Tom Tromey
@ 2018-05-25 16:55 ` Pedro Alves
2018-05-25 17:12 ` Tom Tromey
0 siblings, 1 reply; 5+ messages in thread
From: Pedro Alves @ 2018-05-25 16:55 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 05/25/2018 04:04 PM, Tom Tromey wrote:
> This removes the remaining cleanups from dbxread.c, via std::vector,
> scoped_restore, and unique_xmalloc_ptr.
>
> Tested by the buildbot, but I'm not sure these code paths are actually
> exercised there.
Maybe not. Could just just smoke test some -gstabs binary, just
in case?
Looks good to me. Just a couple comments below.
> /* The actual list and controling variables. */
> -static struct header_file_location *bincl_list, *next_bincl;
> -static int bincls_allocated;
> +static std::vector<struct header_file_location> *bincl_list;
I guess the "controlling variables" was "bincls_allocated", which
is now gone. Maybe adjust the comment?
> /* Add a bincl to the list. */
>
> static void
> add_bincl_to_list (struct partial_symtab *pst, const char *name, int instance)
> {
> - if (next_bincl >= bincl_list + bincls_allocated)
> - {
> - int offset = next_bincl - bincl_list;
> + bincl_list->emplace_back ();
> + struct header_file_location *next_bincl = &bincl_list->back ();
>
> - bincls_allocated *= 2;
> - bincl_list = (struct header_file_location *)
> - xrealloc ((char *) bincl_list,
> - bincls_allocated * sizeof (struct header_file_location));
> - next_bincl = bincl_list + offset;
> - }
> next_bincl->pst = pst;
> next_bincl->instance = instance;
> - next_bincl++->name = name;
> + next_bincl->name = name;
> }
I guess we could add a ctor to header_file_location, so
we'd could write:
bincl_list->emplace_back (pst, name, instance);
Could even remove add_bincl_to_list then, I guess.
Anyway, I totally understand if you want to stay strictly
focused on the cleanups aspect, and this is not a request.
That is OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Remove cleanups from dbxread.c
2018-05-25 16:55 ` Pedro Alves
@ 2018-05-25 17:12 ` Tom Tromey
2018-05-25 19:20 ` Pedro Alves
0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2018-05-25 17:12 UTC (permalink / raw)
To: Pedro Alves; +Cc: Tom Tromey, gdb-patches
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Maybe not. Could just just smoke test some -gstabs binary, just
Pedro> in case?
Actually, there is testsuite/gdb.stabs, so maybe it is ok.
Pedro> I guess we could add a ctor to header_file_location, so
Pedro> we'd could write:
Pedro> bincl_list-> emplace_back (pst, name, instance);
Pedro> Could even remove add_bincl_to_list then, I guess.
Pedro> Anyway, I totally understand if you want to stay strictly
Pedro> focused on the cleanups aspect, and this is not a request.
It seemed like a good idea, and wasn't too hard, so I did it. If it
were harder, then I guess I wouldn't bother, since stabs seem to be on
their way out.
Let me know what you think of this.
Tom
commit b185c7200d3a7b55d02bb6acb87dfa0239bca1fc
Author: Tom Tromey <tom@tromey.com>
Date: Thu May 24 22:09:24 2018 -0600
Remove cleanups from dbxread.c
This removes the remaining cleanups from dbxread.c, via std::vector,
scoped_restore, and unique_xmalloc_ptr.
Tested by the buildbot.
ChangeLog
2018-05-25 Tom Tromey <tom@tromey.com>
* dbxread.c (init_bincl_list): Remove.
(bincl_list): Now a std::vector.
(bincls_allocated, next_bincl): Remove.
(free_bincl_list, do_free_bincl_list_cleanup)
(make_cleanup_free_bincl_list): Remove.
(dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
unique_xmalloc_ptr.
(find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
(struct header_file_location): Add constructor.
(add_bincl_to_list): Remove.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b697326e56..185325544e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,18 @@
2018-05-25 Tom Tromey <tom@tromey.com>
+ * dbxread.c (init_bincl_list): Remove.
+ (bincl_list): Now a std::vector.
+ (bincls_allocated, next_bincl): Remove.
+ (free_bincl_list, do_free_bincl_list_cleanup)
+ (make_cleanup_free_bincl_list): Remove.
+ (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
+ unique_xmalloc_ptr.
+ (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
+ (struct header_file_location): Add constructor.
+ (add_bincl_to_list): Remove.
+
+2018-05-25 Tom Tromey <tom@tromey.com>
+
* remote.c (remote_target::remote_file_get): Use
gdb::byte_vector.
(remote_target::remote_file_put): Likewise.
diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 95b614cdae..c5acae9583 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -236,15 +236,22 @@ find_text_range (bfd * sym_bfd, struct objfile *objfile)
struct header_file_location
{
+ header_file_location (const char *name_, int instance_,
+ struct partial_symtab *pst_)
+ : name (name_),
+ instance (instance_),
+ pst (pst_)
+ {
+ }
+
const char *name; /* Name of header file */
int instance; /* See above */
struct partial_symtab *pst; /* Partial symtab that has the
BINCL/EINCL defs for this file. */
};
-/* The actual list and controling variables. */
-static struct header_file_location *bincl_list, *next_bincl;
-static int bincls_allocated;
+/* The list of bincls. */
+static std::vector<struct header_file_location> *bincl_list;
/* Local function prototypes. */
@@ -257,15 +264,9 @@ static void dbx_psymtab_to_symtab_1 (struct objfile *, struct partial_symtab *);
static void read_dbx_symtab (minimal_symbol_reader &, struct objfile *);
-static void free_bincl_list (struct objfile *);
-
static struct partial_symtab *find_corresponding_bincl_psymtab (const char *,
int);
-static void add_bincl_to_list (struct partial_symtab *, const char *, int);
-
-static void init_bincl_list (int, struct objfile *);
-
static const char *dbx_next_symbol_text (struct objfile *);
static void fill_symbuf (bfd *);
@@ -855,36 +856,6 @@ dbx_next_symbol_text (struct objfile *objfile)
return nlist.n_strx + stringtab_global + file_string_table_offset;
}
\f
-/* Initialize the list of bincls to contain none and have some
- allocated. */
-
-static void
-init_bincl_list (int number, struct objfile *objfile)
-{
- bincls_allocated = number;
- next_bincl = bincl_list = XNEWVEC (struct header_file_location,
- bincls_allocated);
-}
-
-/* Add a bincl to the list. */
-
-static void
-add_bincl_to_list (struct partial_symtab *pst, const char *name, int instance)
-{
- if (next_bincl >= bincl_list + bincls_allocated)
- {
- int offset = next_bincl - bincl_list;
-
- bincls_allocated *= 2;
- bincl_list = (struct header_file_location *)
- xrealloc ((char *) bincl_list,
- bincls_allocated * sizeof (struct header_file_location));
- next_bincl = bincl_list + offset;
- }
- next_bincl->pst = pst;
- next_bincl->instance = instance;
- next_bincl++->name = name;
-}
/* Given a name, value pair, find the corresponding
bincl in the list. Return the partial symtab associated
@@ -893,38 +864,15 @@ add_bincl_to_list (struct partial_symtab *pst, const char *name, int instance)
static struct partial_symtab *
find_corresponding_bincl_psymtab (const char *name, int instance)
{
- struct header_file_location *bincl;
-
- for (bincl = bincl_list; bincl < next_bincl; bincl++)
- if (bincl->instance == instance
- && strcmp (name, bincl->name) == 0)
- return bincl->pst;
+ for (struct header_file_location &bincl : *bincl_list)
+ if (bincl.instance == instance
+ && strcmp (name, bincl.name) == 0)
+ return bincl.pst;
repeated_header_complaint (name, symnum);
return (struct partial_symtab *) 0;
}
-/* Free the storage allocated for the bincl list. */
-
-static void
-free_bincl_list (struct objfile *objfile)
-{
- xfree (bincl_list);
- bincls_allocated = 0;
-}
-
-static void
-do_free_bincl_list_cleanup (void *objfile)
-{
- free_bincl_list ((struct objfile *) objfile);
-}
-
-static struct cleanup *
-make_cleanup_free_bincl_list (struct objfile *objfile)
-{
- return make_cleanup (do_free_bincl_list_cleanup, objfile);
-}
-
/* Set namestring based on nlist. If the string table index is invalid,
give a fake name, and print a single error message per symbol file read,
rather than abort the symbol reading or flood the user with messages. */
@@ -1019,7 +967,6 @@ read_dbx_symtab (minimal_symbol_reader &reader, struct objfile *objfile)
int nsl;
int past_first_source_file = 0;
CORE_ADDR last_function_start = 0;
- struct cleanup *back_to;
bfd *abfd;
int textlow_not_set;
int data_sect_index;
@@ -1060,8 +1007,9 @@ read_dbx_symtab (minimal_symbol_reader &reader, struct objfile *objfile)
sizeof (struct partial_symtab *));
/* Init bincl list */
- init_bincl_list (20, objfile);
- back_to = make_cleanup_free_bincl_list (objfile);
+ std::vector<struct header_file_location> bincl_storage;
+ scoped_restore restore_bincl_global
+ = make_scoped_restore (&bincl_list, &bincl_storage);
set_last_source_file (NULL);
@@ -1390,7 +1338,7 @@ read_dbx_symtab (minimal_symbol_reader &reader, struct objfile *objfile)
namestring, symnum);
continue;
}
- add_bincl_to_list (pst, namestring, nlist.n_value);
+ bincl_list->emplace_back (namestring, nlist.n_value, pst);
/* Mark down an include file in the current psymtab. */
@@ -1977,8 +1925,6 @@ read_dbx_symtab (minimal_symbol_reader &reader, struct objfile *objfile)
text_end > pst->texthigh ? text_end : pst->texthigh,
dependency_list, dependencies_used, textlow_not_set);
}
-
- do_cleanups (back_to);
}
/* Allocate and partially fill a partial symtab. It will be
@@ -2240,8 +2186,6 @@ dbx_read_symtab (struct partial_symtab *self, struct objfile *objfile)
if (LDSYMLEN (self) || self->number_of_dependencies)
{
- struct cleanup *back_to;
-
/* Print the message now, before reading the string table,
to avoid disconcerting pauses. */
if (info_verbose)
@@ -2252,22 +2196,20 @@ dbx_read_symtab (struct partial_symtab *self, struct objfile *objfile)
next_symbol_text_func = dbx_next_symbol_text;
- back_to = make_cleanup (null_cleanup, NULL);
-
- if (DBX_STAB_SECTION (objfile))
- {
- stabs_data
- = symfile_relocate_debug_section (objfile,
- DBX_STAB_SECTION (objfile),
- NULL);
-
- if (stabs_data)
- make_cleanup (free_current_contents, (void *) &stabs_data);
- }
-
- dbx_psymtab_to_symtab_1 (objfile, self);
+ {
+ scoped_restore restore_stabs_data = make_scoped_restore (&stabs_data);
+ gdb::unique_xmalloc_ptr<gdb_byte> data_holder;
+ if (DBX_STAB_SECTION (objfile))
+ {
+ stabs_data
+ = symfile_relocate_debug_section (objfile,
+ DBX_STAB_SECTION (objfile),
+ NULL);
+ data_holder.reset (stabs_data);
+ }
- do_cleanups (back_to);
+ dbx_psymtab_to_symtab_1 (objfile, self);
+ }
/* Match with global symbols. This only needs to be done once,
after all of the symtabs and dependencies have been read in. */
@@ -3146,7 +3088,6 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect,
int val;
bfd *sym_bfd = objfile->obfd;
char *name = bfd_get_filename (sym_bfd);
- struct cleanup *back_to = make_cleanup (null_cleanup, NULL);
/* Find the first and last text address. dbx_symfile_read seems to
want this. */
@@ -3184,9 +3125,13 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect,
symbuf_read = 0;
symbuf_left = bfd_section_size (objfile->obfd, stabsect);
+
+ scoped_restore restore_stabs_data = make_scoped_restore (&stabs_data);
+ gdb::unique_xmalloc_ptr<gdb_byte> data_holder;
+
stabs_data = symfile_relocate_debug_section (objfile, stabsect, NULL);
if (stabs_data)
- make_cleanup (free_current_contents, (void *) &stabs_data);
+ data_holder.reset (stabs_data);
/* In an elf file, we've already installed the minimal symbols that came
from the elf (non-stab) symbol table, so always act like an
@@ -3195,8 +3140,6 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect,
table and normal symbol entries won't be in the ".stab" section; but in
case it does, it will install them itself. */
dbx_symfile_read (objfile, 0);
-
- do_cleanups (back_to);
}
\f
/* Scan and build partial symbols for a file with special sections for stabs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Remove cleanups from dbxread.c
2018-05-25 17:12 ` Tom Tromey
@ 2018-05-25 19:20 ` Pedro Alves
2018-05-25 19:50 ` Tom Tromey
0 siblings, 1 reply; 5+ messages in thread
From: Pedro Alves @ 2018-05-25 19:20 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 05/25/2018 05:55 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> Maybe not. Could just just smoke test some -gstabs binary, just
> Pedro> in case?
>
> Actually, there is testsuite/gdb.stabs, so maybe it is ok.
Only the weird.exp test it seems, which builds some stabs manually.
The other tests just use the default compile routines AFAICT, so
they end up with dwarf anyway.
>
> Pedro> I guess we could add a ctor to header_file_location, so
> Pedro> we'd could write:
> Pedro> bincl_list-> emplace_back (pst, name, instance);
> Pedro> Could even remove add_bincl_to_list then, I guess.
>
> Pedro> Anyway, I totally understand if you want to stay strictly
> Pedro> focused on the cleanups aspect, and this is not a request.
>
> It seemed like a good idea, and wasn't too hard, so I did it. If it
> were harder, then I guess I wouldn't bother, since stabs seem to be on
> their way out.
Yeah.
>
> Let me know what you think of this.
OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Remove cleanups from dbxread.c
2018-05-25 19:20 ` Pedro Alves
@ 2018-05-25 19:50 ` Tom Tromey
0 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey @ 2018-05-25 19:50 UTC (permalink / raw)
To: Pedro Alves; +Cc: Tom Tromey, gdb-patches
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Only the weird.exp test it seems, which builds some stabs manually.
Pedro> The other tests just use the default compile routines AFAICT, so
Pedro> they end up with dwarf anyway.
i ran a few things with --target_board=stabs to make sure that there at
least weren't new crashes.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-25 19:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-25 16:07 [RFA] Remove cleanups from dbxread.c Tom Tromey
2018-05-25 16:55 ` Pedro Alves
2018-05-25 17:12 ` Tom Tromey
2018-05-25 19:20 ` Pedro Alves
2018-05-25 19:50 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox