From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11098 invoked by alias); 25 May 2018 18:44:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11072 invoked by uid 89); 25 May 2018 18:44:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1049 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 May 2018 18:44:54 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E89E7D85B; Fri, 25 May 2018 18:44:53 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F91F2026DEF; Fri, 25 May 2018 18:44:52 +0000 (UTC) Subject: Re: [RFA] Remove cleanups from dbxread.c To: Tom Tromey References: <20180525150441.25246-1-tom@tromey.com> <878t871xq4.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <00c05817-d9d3-b75d-25a5-9092f7cec07c@redhat.com> Date: Fri, 25 May 2018 19:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <878t871xq4.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00698.txt.bz2 On 05/25/2018 05:55 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Maybe not. Could just just smoke test some -gstabs binary, just > Pedro> in case? > > Actually, there is testsuite/gdb.stabs, so maybe it is ok. Only the weird.exp test it seems, which builds some stabs manually. The other tests just use the default compile routines AFAICT, so they end up with dwarf anyway. > > Pedro> I guess we could add a ctor to header_file_location, so > Pedro> we'd could write: > Pedro> bincl_list-> emplace_back (pst, name, instance); > Pedro> Could even remove add_bincl_to_list then, I guess. > > Pedro> Anyway, I totally understand if you want to stay strictly > Pedro> focused on the cleanups aspect, and this is not a request. > > It seemed like a good idea, and wasn't too hard, so I did it. If it > were harder, then I guess I wouldn't bother, since stabs seem to be on > their way out. Yeah. > > Let me know what you think of this. OK. Thanks, Pedro Alves