[RFA] set PROTOTYPED flag for pascal functions in dwarf2read.c

[RFA] set PROTOTYPED flag for pascal functions in dwarf2read.c

[Pierre Muller]

  According to Jonas Maebe, all pascal functions are
prototyped (as are C++ and Java functions).
  I did not find any code that really uses the fact
that a function is prototyped, but I am willing to
commit this after approval by dwarf2 maintainers
so that I can close one more bug report...


Pierre Muller

2007-09-26  Pierre Muller  <muller@ics.u-strasbg.fr>

        * Fix PR pascal/2231
        dwarf2read.c (read_subroutine_type):
        All pascal functions are prototyped.


Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.231
diff -u -p -r1.231 dwarf2read.c
--- dwarf2read.c        5 Sep 2007 00:51:48 -0000       1.231
+++ dwarf2read.c        26 Sep 2007 12:38:19 -0000
@@ -4744,11 +4744,12 @@ read_subroutine_type (struct die_info *d
   type = die_type (die, cu);
   ftype = make_function_type (type, (struct type **) 0);

-  /* All functions in C++ and Java have prototypes.  */
+  /* All functions in C++, Pascal and Java have prototypes.  */
   attr = dwarf2_attr (die, DW_AT_prototyped, cu);
   if ((attr && (DW_UNSND (attr) != 0))
       || cu->language == language_cplus
-      || cu->language == language_java)
+      || cu->language == language_java
+      || cu->language == language_pascal)
     TYPE_FLAGS (ftype) |= TYPE_FLAG_PROTOTYPED;

   if (die->child != NULL)

Re: [RFA] set PROTOTYPED flag for pascal functions in dwarf2read.c

[Daniel Jacobowitz]

On Wed, Sep 26, 2007 at 02:49:49PM +0200, Pierre Muller wrote:
>   According to Jonas Maebe, all pascal functions are
> prototyped (as are C++ and Java functions).
>   I did not find any code that really uses the fact
> that a function is prototyped, but I am willing to
> commit this after approval by dwarf2 maintainers
> so that I can close one more bug report...

This affects the way parameters are passed.  In C, the usual
consequence is that float is promoted to double when calling an
unprototyped function, but preserved as float when calling
a prototyped function.

> 2007-09-26  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>         * Fix PR pascal/2231
>         dwarf2read.c (read_subroutine_type):
>         All pascal functions are prototyped.

OK.

-- 
Daniel Jacobowitz
CodeSourcery

RE: [RFA] set PROTOTYPED flag for pascal functions in dwarf2read.c

[Pierre Muller]

 Thanks

Committed.

Pierre Muller

> -----Original Message-----
> From: Daniel Jacobowitz [mailto:drow@false.org]
> Sent: Wednesday, September 26, 2007 2:57 PM
> To: Pierre Muller
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFA] set PROTOTYPED flag for pascal functions in
> dwarf2read.c
> 
> On Wed, Sep 26, 2007 at 02:49:49PM +0200, Pierre Muller wrote:
> >   According to Jonas Maebe, all pascal functions are
> > prototyped (as are C++ and Java functions).
> >   I did not find any code that really uses the fact
> > that a function is prototyped, but I am willing to
> > commit this after approval by dwarf2 maintainers
> > so that I can close one more bug report...
> 
> This affects the way parameters are passed.  In C, the usual
> consequence is that float is promoted to double when calling an
> unprototyped function, but preserved as float when calling
> a prototyped function.
> 
> > 2007-09-26  Pierre Muller  <muller@ics.u-strasbg.fr>
> >
> >         * Fix PR pascal/2231
> >         dwarf2read.c (read_subroutine_type):
> >         All pascal functions are prototyped.
> 
> OK.
> 
> --
> Daniel Jacobowitz
> CodeSourcery