From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28461 invoked by alias); 26 Sep 2007 12:49:59 -0000 Received: (qmail 28451 invoked by uid 22791); 26 Sep 2007 12:49:57 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 26 Sep 2007 12:49:55 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id EB6A918701C for ; Wed, 26 Sep 2007 14:54:47 +0200 (CEST) From: "Pierre Muller" To: Subject: [RFA] set PROTOTYPED flag for pascal functions in dwarf2read.c Date: Wed, 26 Sep 2007 12:49:00 -0000 Message-ID: <003601c8003b$b9a3cf50$2ceb6df0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00361.txt.bz2 According to Jonas Maebe, all pascal functions are prototyped (as are C++ and Java functions). I did not find any code that really uses the fact that a function is prototyped, but I am willing to commit this after approval by dwarf2 maintainers so that I can close one more bug report... Pierre Muller 2007-09-26 Pierre Muller * Fix PR pascal/2231 dwarf2read.c (read_subroutine_type): All pascal functions are prototyped. Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.231 diff -u -p -r1.231 dwarf2read.c --- dwarf2read.c 5 Sep 2007 00:51:48 -0000 1.231 +++ dwarf2read.c 26 Sep 2007 12:38:19 -0000 @@ -4744,11 +4744,12 @@ read_subroutine_type (struct die_info *d type = die_type (die, cu); ftype = make_function_type (type, (struct type **) 0); - /* All functions in C++ and Java have prototypes. */ + /* All functions in C++, Pascal and Java have prototypes. */ attr = dwarf2_attr (die, DW_AT_prototyped, cu); if ((attr && (DW_UNSND (attr) != 0)) || cu->language == language_cplus - || cu->language == language_java) + || cu->language == language_java + || cu->language == language_pascal) TYPE_FLAGS (ftype) |= TYPE_FLAG_PROTOTYPED; if (die->child != NULL)