From: "Michael Snyder" <msnyder@sonic.net>
To: "Joel Brobecker" <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] ada-lang.c, null pointer
Date: Tue, 14 Aug 2007 05:49:00 -0000 [thread overview]
Message-ID: <002101c7de35$aa7e8600$677ba8c0@sonic.net> (raw)
In-Reply-To: <20070814042242.GA11498@adacore.com>
> Hi Michael,
>
> > 2007-08-11 Michael Snyder <msnyder@access-company.com>
> >
> > * ada-lang.c (field_alignment): Guard against NULL.
>
> Thanks again for your patch.
>
> May I propose another patch that is very close in spirit? The diff
> is slightly bigger, but it makes the code check for a null name
> only once, and allows us to know at a glance what we do in this case.
>
> Let me know what you think.
> (proposed patch reg-tested)
Yeah, Joel, that looks fine to me. You want to check it in?
Michael
next prev parent reply other threads:[~2007-08-14 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-11 20:29 msnyder
2007-08-11 20:31 ` msnyder
2007-08-14 4:19 ` Joel Brobecker
2007-08-14 5:49 ` Michael Snyder [this message]
2007-08-14 20:21 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002101c7de35$aa7e8600$677ba8c0@sonic.net' \
--to=msnyder@sonic.net \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox