From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29251 invoked by alias); 14 Aug 2007 05:49:26 -0000 Received: (qmail 29241 invoked by uid 22791); 14 Aug 2007 05:49:25 -0000 X-Spam-Check-By: sourceware.org Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Aug 2007 05:49:21 +0000 Received: from snyder (209-204-172-156.dsl.dynamic.sonic.net [209.204.172.156]) by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with SMTP id l7E5nCuV023205; Mon, 13 Aug 2007 22:49:12 -0700 Message-ID: <002101c7de35$aa7e8600$677ba8c0@sonic.net> Reply-To: "Michael Snyder" From: "Michael Snyder" To: "Joel Brobecker" Cc: References: <8146.12.7.175.2.1186864158.squirrel@webmail.sonic.net> <25376.12.7.175.2.1186864263.squirrel@webmail.sonic.net> <20070814042242.GA11498@adacore.com> Subject: Re: [PATCH] ada-lang.c, null pointer Date: Tue, 14 Aug 2007 05:49:00 -0000 X-Mailer: Microsoft Outlook Express 6.00.2800.1437 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00280.txt.bz2 > Hi Michael, > > > 2007-08-11 Michael Snyder > > > > * ada-lang.c (field_alignment): Guard against NULL. > > Thanks again for your patch. > > May I propose another patch that is very close in spirit? The diff > is slightly bigger, but it makes the code check for a null name > only once, and allows us to know at a glance what we do in this case. > > Let me know what you think. > (proposed patch reg-tested) Yeah, Joel, that looks fine to me. You want to check it in? Michael