Re: [PATCH] ada-lang.c, null pointer

[msnyder@sonic.net]

[-- Attachment #1: Type: text/plain, Size: 139 bytes --]

> According to the first line of the function, name may be null.
> In which case, we'll crash on the next line.

Err, here's the patch...


[-- Attachment #2: 55.txt --]
[-- Type: text/plain, Size: 812 bytes --]

2007-08-11  Michael Snyder  <msnyder@access-company.com>

	* ada-lang.c (field_alignment): Guard against NULL.

Index: ada-lang.c
===================================================================
RCS file: /cvs/src/src/gdb/ada-lang.c,v
retrieving revision 1.100
diff -p -r1.100 ada-lang.c
*** ada-lang.c	6 Aug 2007 20:07:44 -0000	1.100
--- ada-lang.c	11 Aug 2007 20:25:00 -0000
*************** field_alignment (struct type *type, int 
*** 6119,6125 ****
    int len = (name == NULL) ? 0 : strlen (name);
    int align_offset;
  
!   if (!isdigit (name[len - 1]))
      return 1;
  
    if (isdigit (name[len - 2]))
--- 6119,6125 ----
    int len = (name == NULL) ? 0 : strlen (name);
    int align_offset;
  
!   if (name == NULL || !isdigit (name[len - 1]))
      return 1;
  
    if (isdigit (name[len - 2]))