From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA] gdbadmin/ss/gdb_find.sh cleanup
Date: Wed, 22 Apr 2009 07:42:00 -0000 [thread overview]
Message-ID: <000b01c9c31d$d0ecfd70$72c6f850$@u-strasbg.fr> (raw)
I looked at gdb_find.sh script and discovered
that some of the excluded files do not exist anymore.
The patch below creates no changes on the ARI output
for me.
The new version of gdb_find.sh is then only:
>>>>>>>>>>>>>>>> `cat gdb_find.sh`
#!/bin/sh
# A find that prunes files that GDB users shouldn't be interested in.
find "$@" \
-name signals -prune -o \
-name testsuite -prune -o \
-name gdbserver -prune -o \
-name gnulib -prune -o \
-name rdi-share -prune -o \
-name osf-share -prune -o \
-name nlm -prune -o \
-name '*-stub.c' -prune -o \
-name '*-exp.c' -prune -o \
-name 'sh64*' -prune -o \
-name remote-mips.c -prune -o \
-type f -name '*.[lyhc]' -print
>>>>>>>>>>>>>>>> end of `cat gdb_find.sh`
Is this patch OK?
I perfectly understand why *-stub.c patterns are excluded,
*-exp.c patterns should not even appear in a distribution of gdb sources,
but this only also doesn't hurt, I am more curious about
'sh64*' and 'remote-mips.c'
sh64* covers
gdb/sh64-tdep.c file
and
config/sh64 directory.
Why are those patterns excluded?
Who are the maintainers of these files?
Should we also remove those two lines?
(I tried removing these two patterns also and I do get
some more warnings in that case).
Pierre Muller
Pascal language support maintainer for GDB
Commit entry:
* remove obsolete patterns
$ cvs diff gdb_find.sh
Index: gdb_find.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_find.sh,v
retrieving revision 1.12
diff -r1.12 gdb_find.sh
15,17d14
< -name ada-lex.c -prune -o \
< -name cp-name-parser.c -prune -o \
< -name stop-gdb.c -prune -o \
19,21d15
< -name lynx-nat.c -prune -o \
< -name ppc-bdm.c -prune -o \
< -name ppc-bdm.c -prune -o \
23,24d16
< -name remote-sds.c -prune -o \
< -name remote-sds.c -prune -o \
Pierre@d620-muller ~/ss
next reply other threads:[~2009-04-22 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 7:42 Pierre Muller [this message]
2009-04-22 17:57 ` Joel Brobecker
2009-04-22 21:41 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01c9c31d$d0ecfd70$72c6f850$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox