From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30308 invoked by alias); 22 Apr 2009 07:42:04 -0000 Received: (qmail 30294 invoked by uid 22791); 22 Apr 2009 07:42:01 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Apr 2009 07:41:56 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n3M7frvw006788 for ; Wed, 22 Apr 2009 09:41:53 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n3M7frJD060224 for ; Wed, 22 Apr 2009 09:41:53 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n3M7fqAO066603 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Wed, 22 Apr 2009 09:41:52 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Subject: [RFA] gdbadmin/ss/gdb_find.sh cleanup Date: Wed, 22 Apr 2009 07:42:00 -0000 Message-ID: <000b01c9c31d$d0ecfd70$72c6f850$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit x-cr-hashedpuzzle: BBrp BlSZ CKEh CgOa D3nl Ebd3 E93B GZnu IJod IW0c IaTV IvIb JrE+ JrvD Miip NGaG;1;ZwBkAGIALQBwAGEAdABjAGgAZQBzAEAAcwBvAHUAcgBjAGUAdwBhAHIAZQAuAG8AcgBnAA==;Sosha1_v1;7;{57F6CEFE-3216-4984-88E2-791549800FB6};bQB1AGwAbABlAHIAQABpAGMAcwAuAHUALQBzAHQAcgBhAHMAYgBnAC4AZgByAA==;Wed, 22 Apr 2009 07:41:54 GMT;WwBSAEYAQQBdACAAZwBkAGIAYQBkAG0AaQBuAC8AcwBzAC8AZwBkAGIAXwBmAGkAbgBkAC4AcwBoACAAYwBsAGUAYQBuAHUAcAA= x-cr-puzzleid: {57F6CEFE-3216-4984-88E2-791549800FB6} Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00584.txt.bz2 I looked at gdb_find.sh script and discovered that some of the excluded files do not exist anymore. The patch below creates no changes on the ARI output for me. The new version of gdb_find.sh is then only: >>>>>>>>>>>>>>>> `cat gdb_find.sh` #!/bin/sh # A find that prunes files that GDB users shouldn't be interested in. find "$@" \ -name signals -prune -o \ -name testsuite -prune -o \ -name gdbserver -prune -o \ -name gnulib -prune -o \ -name rdi-share -prune -o \ -name osf-share -prune -o \ -name nlm -prune -o \ -name '*-stub.c' -prune -o \ -name '*-exp.c' -prune -o \ -name 'sh64*' -prune -o \ -name remote-mips.c -prune -o \ -type f -name '*.[lyhc]' -print >>>>>>>>>>>>>>>> end of `cat gdb_find.sh` Is this patch OK? I perfectly understand why *-stub.c patterns are excluded, *-exp.c patterns should not even appear in a distribution of gdb sources, but this only also doesn't hurt, I am more curious about 'sh64*' and 'remote-mips.c' sh64* covers gdb/sh64-tdep.c file and config/sh64 directory. Why are those patterns excluded? Who are the maintainers of these files? Should we also remove those two lines? (I tried removing these two patterns also and I do get some more warnings in that case). Pierre Muller Pascal language support maintainer for GDB Commit entry: * remove obsolete patterns $ cvs diff gdb_find.sh Index: gdb_find.sh =================================================================== RCS file: /cvs/gdbadmin/ss/gdb_find.sh,v retrieving revision 1.12 diff -r1.12 gdb_find.sh 15,17d14 < -name ada-lex.c -prune -o \ < -name cp-name-parser.c -prune -o \ < -name stop-gdb.c -prune -o \ 19,21d15 < -name lynx-nat.c -prune -o \ < -name ppc-bdm.c -prune -o \ < -name ppc-bdm.c -prune -o \ 23,24d16 < -name remote-sds.c -prune -o \ < -name remote-sds.c -prune -o \ Pierre@d620-muller ~/ss