Re: [RFA] gdbadmin/ss/gdb_find.sh cleanup

Joel Brobecker
2009-04-22T17:57:05Z

> -name signals -prune -o \

I can't find a "signals" directory. Can you double-check and remove
this line if I'm right? (if it makes sense to you too)

> -name testsuite -prune -o \
> -name gdbserver -prune -o \

I wonder if we want to start tracking the gdbserver sources as well.
Just a thought...

> -name gnulib -prune -o \
> -name rdi-share -prune -o \

Can't find this directory either...

> -name remote-mips.c -prune -o \

This file started being excluded in Jan 2005. There's definitely
been some activity on the associated target, so I'm thinking it might
make sense to stop excluding it.

> 'sh64*' and 'remote-mips.c'
> sh64* covers
> gdb/sh64-tdep.c file
> and
> config/sh64 directory.

Strange, I can't find that config/sh64 directory either.

> Why are those patterns excluded?

Here what the CVS log says about the change that introduced the
exclusion:

revision 1.7
date: 2004/08/03 13:09:19; author: cagney; state: Exp; lines: +9 -2
Ignore (hardwired) broken targets.

Since then, it appears that Corinna Vinshen has done some work to
revive the target. So we might again want to remove them from the
exclusion list. To be checked with Corinna?

> < -name ada-lex.c -prune -o \

DanielJ specifically removed this file from the list. I'm not sure
whether anything changed that would make us change our decision.
This is a generated file - perhaps we should check the source .l
file instead (which I think we do).

> < -name cp-name-parser.c -prune -o \

Same here. This is a generated file.

> < -name stop-gdb.c -prune -o \
> 19,21d15
> < -name lynx-nat.c -prune -o \
> < -name ppc-bdm.c -prune -o \
> < -name ppc-bdm.c -prune -o \
> 23,24d16
> < -name remote-sds.c -prune -o \
> < -name remote-sds.c -prune -o \

The rest seems OK to me.

--
Joel