RE: [RFC] move strace call to gdb_init? (away from testcase)

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

> Runtest already does the call to strace:
> 
>         "--str*" {                      # (--strace) expect trace level
>             set tracelevel $optarg
>             strace $tracelevel

  I looked into dejagnu history on savanna git 
http://git.savannah.gnu.org/gitweb/?p=dejagnu.git;a=summary
and checked that indeed this 
strace code exists at least since initial repository creation in 2001.
 
> So, I don't think that setting it ourselves is going to be doing
> anything. As a test, I tried with various levels of strace-ing,
> and nothing seemed to change. In particular, the output in gdb.log
> remained the same with or without.
> 
> (it might have done something if each testcase script was executed
> as it own expect process, but in fact, there is only one expect
> process, and testcases are just "source"-ed)
> 
> So, I think we could just nuke the thing. Alternatively, we could
> be a little extra conservative, and reset it systematically at
> the start of every testcase, JIC a testcase changes the strace
> level. The best place to do that is in proc gdb_init (lib/gdb.exp).

  No testcase changes tracelevel
for now..
 
> WDYT?

  What about removing it completely
and adding tracelevel variable to the
list of banned variables in lib/gdb.exp
currently, this list has only two items:
gdb.exp, line 2767:  set banned_variables { bug_id prms_id }

just add tracelevel variable to this list
and remove all
if {$tracelevel} {
  strace $tracelevel
}
from all testcases.


Pierre Muller
GDB pascal language maintainer