From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [RFC] move strace call to gdb_init? (away from testcase)
Date: Wed, 23 Feb 2011 08:46:00 -0000 [thread overview]
Message-ID: <20110223072123.GQ2617@adacore.com> (raw)
Hello,
One of the things I constantly notice everytime I start writing
a new testcase is that we always start it exactly the same way:
if $tracelevel then {
strace $tracelevel
}
I tried to research a bit how this works. As far as I can tell,
the "tracelevel" variable is controlled via runtest's --strace
command-line switch.
Runtest already does the call to strace:
"--str*" { # (--strace) expect trace level
set tracelevel $optarg
strace $tracelevel
So, I don't think that setting it ourselves is going to be doing
anything. As a test, I tried with various levels of strace-ing,
and nothing seemed to change. In particular, the output in gdb.log
remained the same with or without.
(it might have done something if each testcase script was executed
as it own expect process, but in fact, there is only one expect
process, and testcases are just "source"-ed)
So, I think we could just nuke the thing. Alternatively, we could
be a little extra conservative, and reset it systematically at
the start of every testcase, JIC a testcase changes the strace
level. The best place to do that is in proc gdb_init (lib/gdb.exp).
WDYT?
--
Joel
next reply other threads:[~2011-02-23 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 8:46 Joel Brobecker [this message]
2011-02-23 9:22 ` Pierre Muller
2011-02-23 9:29 ` Joel Brobecker
2011-02-23 14:56 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223072123.GQ2617@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox