From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4347 invoked by alias); 23 Feb 2011 08:46:01 -0000 Received: (qmail 4330 invoked by uid 22791); 23 Feb 2011 08:46:00 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Feb 2011 08:45:54 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p1N8jbsu025231 ; Wed, 23 Feb 2011 09:45:37 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms7.u-strasbg.fr [130.79.204.16]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p1N8jbS0075815 ; Wed, 23 Feb 2011 09:45:37 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p1N8ja4n070010 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Wed, 23 Feb 2011 09:45:37 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <20110223072123.GQ2617@adacore.com> In-Reply-To: <20110223072123.GQ2617@adacore.com> Subject: RE: [RFC] move strace call to gdb_init? (away from testcase) Date: Wed, 23 Feb 2011 09:22:00 -0000 Message-ID: <000901cbd336$0a273ef0$1e75bcd0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00639.txt.bz2 > Runtest already does the call to strace: > > "--str*" { # (--strace) expect trace level > set tracelevel $optarg > strace $tracelevel I looked into dejagnu history on savanna git http://git.savannah.gnu.org/gitweb/?p=dejagnu.git;a=summary and checked that indeed this strace code exists at least since initial repository creation in 2001. > So, I don't think that setting it ourselves is going to be doing > anything. As a test, I tried with various levels of strace-ing, > and nothing seemed to change. In particular, the output in gdb.log > remained the same with or without. > > (it might have done something if each testcase script was executed > as it own expect process, but in fact, there is only one expect > process, and testcases are just "source"-ed) > > So, I think we could just nuke the thing. Alternatively, we could > be a little extra conservative, and reset it systematically at > the start of every testcase, JIC a testcase changes the strace > level. The best place to do that is in proc gdb_init (lib/gdb.exp). No testcase changes tracelevel for now.. > WDYT? What about removing it completely and adding tracelevel variable to the list of banned variables in lib/gdb.exp currently, this list has only two items: gdb.exp, line 2767: set banned_variables { bug_id prms_id } just add tracelevel variable to this list and remove all if {$tracelevel} { strace $tracelevel } from all testcases. Pierre Muller GDB pascal language maintainer