From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in windows_xfer_memory function
Date: Mon, 02 Sep 2013 12:48:00 -0000 [thread overview]
Message-ID: <000001cea7da$b431e140$1c95a3c0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <522485BB.8000904@redhat.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : lundi 2 septembre 2013 14:34
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in
> windows_xfer_memory function
>
> On 09/01/2013 11:10 PM, Pierre Muller wrote:
> >
> > PS: the use of plongest function is because I got an warning about %d
> > used for 'long long integer' type.
>
> Then that's a regression from my deprecated_xfer_memory change.
> Please keep logically independent changes as separate patches.
I just noticed the problem while
trying to update the patch...
You are off course right that this should be separate...
> > 2013-09-01 Pierre Muller <muller@sourceware.org>
> >
> > * windows-nat.c (windows_xfer_memory): Fix compilation failure
> > by use of plongest function.
>
> This part is OK. Please split it out, and commit it.
Done and committed,
thanks,
Pierre
PS: Do you want me to resubmit and new version of the ERROR_PARTIAL_COPY
RFA?
next prev parent reply other threads:[~2013-09-02 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5223bb46.c6c0420a.5a41.008dSMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-02 12:34 ` Pedro Alves
2013-09-02 12:48 ` Pierre Muller [this message]
2013-09-02 12:50 ` Pedro Alves
2013-09-02 13:05 ` Pierre Muller
2013-09-02 13:19 ` Pedro Alves
2013-09-02 13:38 ` [RFA] gdbserver/win32-low.c: Check Read/WriteProcessMemory return value (followup to [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in windows_xfer_memory function) Pierre Muller
[not found] ` <522494dc.297a420a.6ab0.6047SMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-02 13:50 ` Pedro Alves
2013-09-02 14:01 ` Pierre Muller
[not found] ` <52249a22.42bd420a.28f1.722cSMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-02 14:09 ` Pedro Alves
2013-09-02 14:18 ` Pierre Muller
[not found] ` <52249e27.e8a4420a.4293.ffff89a0SMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-02 14:19 ` Pedro Alves
2013-09-02 14:25 ` [RFA-v2] " Pierre Muller
2013-09-02 14:29 ` Pedro Alves
2013-09-02 14:35 ` Pierre Muller
2013-09-01 22:10 [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in windows_xfer_memory function Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cea7da$b431e140$1c95a3c0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox