* [lttng-dev] Compile fix for urcu-bp.c
@ 2024-03-29 14:06 Duncan Sands via lttng-dev
2024-04-01 14:03 ` Mathieu Desnoyers via lttng-dev
0 siblings, 1 reply; 2+ messages in thread
From: Duncan Sands via lttng-dev @ 2024-03-29 14:06 UTC (permalink / raw)
To: lttng-dev
--- src/urcu-bp.c
+++ src/urcu-bp.c
@@ -409,7 +409,7 @@ void expand_arena(struct registry_arena *arena)
new_chunk_size_bytes, 0);
if (new_chunk != MAP_FAILED) {
/* Should not have moved. */
- assert(new_chunk == last_chunk);
+ urcu_posix_assert(new_chunk == last_chunk);
memset((char *) last_chunk + old_chunk_size_bytes, 0,
new_chunk_size_bytes - old_chunk_size_bytes);
last_chunk->capacity = new_capacity;
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [lttng-dev] Compile fix for urcu-bp.c
2024-03-29 14:06 [lttng-dev] Compile fix for urcu-bp.c Duncan Sands via lttng-dev
@ 2024-04-01 14:03 ` Mathieu Desnoyers via lttng-dev
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Desnoyers via lttng-dev @ 2024-04-01 14:03 UTC (permalink / raw)
To: Duncan Sands, lttng-dev
Hi,
There are a few things missing before I can take this patch:
- Missing commit message describing the issue,
- Missing "Signed-off-by" tag.
Thanks!
Mathieu
On 2024-03-29 10:06, Duncan Sands via lttng-dev wrote:
> --- src/urcu-bp.c
> +++ src/urcu-bp.c
> @@ -409,7 +409,7 @@ void expand_arena(struct registry_arena *arena)
> new_chunk_size_bytes, 0);
> if (new_chunk != MAP_FAILED) {
> /* Should not have moved. */
> - assert(new_chunk == last_chunk);
> + urcu_posix_assert(new_chunk == last_chunk);
> memset((char *) last_chunk + old_chunk_size_bytes, 0,
> new_chunk_size_bytes - old_chunk_size_bytes);
> last_chunk->capacity = new_capacity;
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-01 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-29 14:06 [lttng-dev] Compile fix for urcu-bp.c Duncan Sands via lttng-dev
2024-04-01 14:03 ` Mathieu Desnoyers via lttng-dev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox