Re: [PATCH] eventfd.cpp: Remove the scope resolution operator

["Jérémie Galarneau via lttng-dev" <lttng-dev@lists.lttng.org>]

Merged in master and stable-2.14, thanks!

Jérémie

On Thu, Jul 24, 2025 at 02:35:51PM +0800, mingli.yu--- via lttng-dev wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
> 
> Remove the scope resolution operator :: to fix the below build failure
> with musl.
>  | ../../../sources/lttng-tools-2.14.0/src/common/eventfd.cpp:18:31: error: expected id-expression before numeric constant
>  |    18 |                 int flags = ::EFD_CLOEXEC;
>  |       |                               ^~~~~~~~~~~
>  | ../../../sources/lttng-tools-2.14.0/src/common/eventfd.cpp:21:36: error: expected id-expression before numeric constant
>  |    21 |                         flags |= ::EFD_SEMAPHORE;
>  |       |                                    ^~~~~~~~~~~~~
> 
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  src/common/eventfd.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/common/eventfd.cpp b/src/common/eventfd.cpp
> index d331bbe40..447520f25 100644
> --- a/src/common/eventfd.cpp
> +++ b/src/common/eventfd.cpp
> @@ -15,10 +15,10 @@
>  
>  lttng::eventfd::eventfd(bool use_semaphore_semantics, std::uint64_t initial_value) :
>  	file_descriptor([use_semaphore_semantics, initial_value]() {
> -		int flags = ::EFD_CLOEXEC;
> +		int flags = EFD_CLOEXEC;
>  
>  		if (use_semaphore_semantics) {
> -			flags |= ::EFD_SEMAPHORE;
> +			flags |= EFD_SEMAPHORE;
>  		}
>  
>  		const auto raw_fd = ::eventfd(initial_value, flags);
> -- 
> 2.34.1
>