Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: "mingli.yu--- via lttng-dev" <lttng-dev@lists.lttng.org>
To: <lttng-dev@lists.lttng.org>
Subject: [PATCH] eventfd.cpp: Remove the scope resolution operator
Date: Thu, 24 Jul 2025 14:35:51 +0800	[thread overview]
Message-ID: <20250724063551.2843528-1-mingli.yu@eng.windriver.com> (raw)

From: Mingli Yu <mingli.yu@windriver.com>

Remove the scope resolution operator :: to fix the below build failure
with musl.
 | ../../../sources/lttng-tools-2.14.0/src/common/eventfd.cpp:18:31: error: expected id-expression before numeric constant
 |    18 |                 int flags = ::EFD_CLOEXEC;
 |       |                               ^~~~~~~~~~~
 | ../../../sources/lttng-tools-2.14.0/src/common/eventfd.cpp:21:36: error: expected id-expression before numeric constant
 |    21 |                         flags |= ::EFD_SEMAPHORE;
 |       |                                    ^~~~~~~~~~~~~

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 src/common/eventfd.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/common/eventfd.cpp b/src/common/eventfd.cpp
index d331bbe40..447520f25 100644
--- a/src/common/eventfd.cpp
+++ b/src/common/eventfd.cpp
@@ -15,10 +15,10 @@
 
 lttng::eventfd::eventfd(bool use_semaphore_semantics, std::uint64_t initial_value) :
 	file_descriptor([use_semaphore_semantics, initial_value]() {
-		int flags = ::EFD_CLOEXEC;
+		int flags = EFD_CLOEXEC;
 
 		if (use_semaphore_semantics) {
-			flags |= ::EFD_SEMAPHORE;
+			flags |= EFD_SEMAPHORE;
 		}
 
 		const auto raw_fd = ::eventfd(initial_value, flags);
-- 
2.34.1


             reply	other threads:[~2025-07-24 14:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24  6:35 mingli.yu--- via lttng-dev [this message]
2025-08-18 19:16 ` Jérémie Galarneau via lttng-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250724063551.2843528-1-mingli.yu@eng.windriver.com \
    --to=lttng-dev@lists.lttng.org \
    --cc=mingli.yu@eng.windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox