[lttng-dev] lttng-modules build failure for 3.12-rc6

[lttng-dev] lttng-modules build failure for 3.12-rc6

[Mathieu Desnoyers]

----- Original Message -----
> From: "Otavio Salvador" <otavio@ossystems.com.br>
> To: "Mathieu Desnoyers" <mathieu.desnoyers at efficios.com>
> Cc: "lttng-dev" <lttng-dev at lists.lttng.org>
> Sent: Thursday, October 31, 2013 2:21:21 PM
> Subject: Re: lttng-modules build failure for 3.12-rc6
> 
> On Thu, Oct 31, 2013 at 4:05 PM, Mathieu Desnoyers
> <mathieu.desnoyers at efficios.com> wrote:
> ...
> >> >> Great; can you backport those to stable-2.3? I'd like to send the
> >> >> update for Yocto including these changes and fix it for us directly
> >> >> there.
> >> >
> >> > Strictly speaking, supporting a new kernel can be seen as a new feature.
> >> > stable-2.3 was released for 3.11. Moreover, 3.12 kernel is still in rc
> >> > stage, so things can still change (and even be reverted, this has
> >> > happened
> >> > in the past).
> >> >
> >> > Unfortunately, we don't add features in the stable branches, only bug
> >> > fixes. But keep in mind that 2.4 should come within the coming weeks.
> >>
> >> Humm in this case stable-2.3 should had a #warning saying it support
> >> kernels up to 3.11 only. As it does not state it somewhere it seems
> >> like a fix for me.
> >>
> >> I will end doing the backport in  this case, but it is something which
> >> could be fixed for 2.4 than and include such warning.
> >
> > I just discussed this with David and Julien, and here is what we came up
> > with:
> >
> > - when a final kernel release comes up (e.g. 3.12), it makes sense to add
> > support for it into a stable release if the modifications are small,
> > - however, it does not make sense to add support for a release candidate
> > Linux kernel, since those are known to change a lot during the RC cycle,
> > (chasing a moving target is never fun)
> >
> > Therefore, I'd be open to cherry-pick the master commits into stable-2.3
> > when 3.12 final comes out. I don't promise I'll remember to do so, so a
> > gentle "ping" when 3.12 final comes out to remind me which commit ID I
> > should cherry-pick from master into stable-2.3 would be welcome,
> 
> Right; it is fine with me. We're close to it as we're in 3.12-rc7.

FYI, I just pushed 3.12 linux kernel support in lttng-modules master and stable-2.3 branches. Please let me know if you see any issue.

Thanks!

Mathieu

> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

[lttng-dev] lttng-modules build failure for 3.12-rc6

[Otavio Salvador]

On Mon, Nov 4, 2013 at 3:34 PM, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> ----- Original Message -----
>> From: "Otavio Salvador" <otavio@ossystems.com.br>
>> To: "Mathieu Desnoyers" <mathieu.desnoyers at efficios.com>
>> Cc: "lttng-dev" <lttng-dev at lists.lttng.org>
>> Sent: Thursday, October 31, 2013 2:21:21 PM
>> Subject: Re: lttng-modules build failure for 3.12-rc6
>>
>> On Thu, Oct 31, 2013 at 4:05 PM, Mathieu Desnoyers
>> <mathieu.desnoyers at efficios.com> wrote:
>> ...
>> >> >> Great; can you backport those to stable-2.3? I'd like to send the
>> >> >> update for Yocto including these changes and fix it for us directly
>> >> >> there.
>> >> >
>> >> > Strictly speaking, supporting a new kernel can be seen as a new feature.
>> >> > stable-2.3 was released for 3.11. Moreover, 3.12 kernel is still in rc
>> >> > stage, so things can still change (and even be reverted, this has
>> >> > happened
>> >> > in the past).
>> >> >
>> >> > Unfortunately, we don't add features in the stable branches, only bug
>> >> > fixes. But keep in mind that 2.4 should come within the coming weeks.
>> >>
>> >> Humm in this case stable-2.3 should had a #warning saying it support
>> >> kernels up to 3.11 only. As it does not state it somewhere it seems
>> >> like a fix for me.
>> >>
>> >> I will end doing the backport in  this case, but it is something which
>> >> could be fixed for 2.4 than and include such warning.
>> >
>> > I just discussed this with David and Julien, and here is what we came up
>> > with:
>> >
>> > - when a final kernel release comes up (e.g. 3.12), it makes sense to add
>> > support for it into a stable release if the modifications are small,
>> > - however, it does not make sense to add support for a release candidate
>> > Linux kernel, since those are known to change a lot during the RC cycle,
>> > (chasing a moving target is never fun)
>> >
>> > Therefore, I'd be open to cherry-pick the master commits into stable-2.3
>> > when 3.12 final comes out. I don't promise I'll remember to do so, so a
>> > gentle "ping" when 3.12 final comes out to remind me which commit ID I
>> > should cherry-pick from master into stable-2.3 would be welcome,
>>
>> Right; it is fine with me. We're close to it as we're in 3.12-rc7.
>
> FYI, I just pushed 3.12 linux kernel support in lttng-modules master and stable-2.3 branches. Please let me know if you see any issue.

Great; thanks.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750