[ltt-dev] [PATCH] Makefile: do not run depmod manually

[ltt-dev] [PATCH] Makefile: do not run depmod manually

[Thomas Petazzoni]

The modules_install target of the kernel build infrastructure already
runs depmod properly, taking into account the cross-compilation
case. Therefore, it is useless to re-run depmod here, and also harmful
since it does not work in cross-compilation contexts (it does the
depmod on the modules installed on the host and not the ones being
built for the target).

Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
---
 Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index c820bcb..5ac13d7 100644
--- a/Makefile
+++ b/Makefile
@@ -47,7 +47,6 @@ default:
 
 modules_install:
 	$(MAKE) -C $(KERNELDIR) M=$(PWD) modules_install
-	/sbin/depmod -a
 
 clean:
 	$(MAKE) -C $(KERNELDIR) M=$(PWD) clean
-- 
1.7.4.1

[ltt-dev] [PATCH] Makefile: do not run depmod manually

[Mathieu Desnoyers]

* Thomas Petazzoni (thomas.petazzoni at free-electrons.com) wrote:
> The modules_install target of the kernel build infrastructure already
> runs depmod properly, taking into account the cross-compilation
> case. Therefore, it is useless to re-run depmod here, and also harmful
> since it does not work in cross-compilation contexts (it does the
> depmod on the modules installed on the host and not the ones being
> built for the target).

Merged into lttng-modules, thanks!

Mathieu

> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  Makefile |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index c820bcb..5ac13d7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -47,7 +47,6 @@ default:
>  
>  modules_install:
>  	$(MAKE) -C $(KERNELDIR) M=$(PWD) modules_install
> -	/sbin/depmod -a
>  
>  clean:
>  	$(MAKE) -C $(KERNELDIR) M=$(PWD) clean
> -- 
> 1.7.4.1
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com

[ltt-dev] [PATCH] Makefile: do not run depmod manually

[Brosseau, Yannick]

Salut Thomas,

On Thu, Nov 3, 2011 at 7:53 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> The modules_install target of the kernel build infrastructure already
> runs depmod properly, taking into account the cross-compilation

That's not exactly true. From the build system we find that:
# Run depmod only if we have System.map and depmod is executable
Since we don't have a System.map file in our module tree, this depmod
execution is mostly a no-op.
So it is necessary to run a depmod manually after installation.

It might be something wrong in the kbuild, but I don't know this
system enough to be able to judge.

Yannick

[ltt-dev] [PATCH] Makefile: do not run depmod manually

[Mathieu Desnoyers]

* Brosseau, Yannick (yannick.brosseau at gmail.com) wrote:
> Salut Thomas,
> 
> On Thu, Nov 3, 2011 at 7:53 AM, Thomas Petazzoni
> <thomas.petazzoni at free-electrons.com> wrote:
> > The modules_install target of the kernel build infrastructure already
> > runs depmod properly, taking into account the cross-compilation
> 
> That's not exactly true. From the build system we find that:
> # Run depmod only if we have System.map and depmod is executable
> Since we don't have a System.map file in our module tree, this depmod
> execution is mostly a no-op.
> So it is necessary to run a depmod manually after installation.
> 
> It might be something wrong in the kbuild, but I don't know this
> system enough to be able to judge.

I added a comment in the README file to that effect. Thanks,

Mathieu

> 
> Yannick
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com