[lttng-dev] Displaying graphical results

[lttng-dev] Displaying graphical results

[tchak adim]

Thanks very much for your responses :)

Regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120603/71346f07/attachment.html>

[lttng-dev] Displaying graphical results

[tchak adim]

for Eclipse tool :
i already follow the different steps to integrate the cft, lttng2 plugins
as described in the link that u give it .
i don't konw how can i visualize the graphics of lttng kernel module traces
using eclipse , can u explain to me how ?

For sourcery tool :
i didn't find the source code, i'm using an ordinary i386 machine running
ubuntu 10.04.

Can u advice me and tell me what i can do ?

thanks in advance !
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120604/ea3e3baf/attachment.html>

[lttng-dev] Displaying graphical results

[Oestman, Fredrik]

Hi Tchak,


>For sourcery tool :
>i didn't find the source code, i'm using an ordinary i386 machine running ubuntu 10.04. 

I'm afraid it's not an open-source tool.


Cheers,

Fredrik

[lttng-dev] UST check pointer/de-reference order

[Oestman, Fredrik]

I stumbled across some code where pointers are de-referenced and then checked for NULL.

Cheers,

Fredrik ?stman


diff --git a/liblttng-ust-ctl/ustctl.c b/liblttng-ust-ctl/ustctl.c
index 9789413..80aed04 100644
--- a/liblttng-ust-ctl/ustctl.c
+++ b/liblttng-ust-ctl/ustctl.c
@@ -732,7 +732,7 @@ void ustctl_unmap_channel(struct lttng_ust_shm_handle *handle)
 struct lttng_ust_lib_ring_buffer *ustctl_open_stream_read(struct lttng_ust_shm_handle *handle,
 	int cpu)
 {
-	struct channel *chan = handle->shadow_chan;
+	struct channel *chan;
 	int *shm_fd, *wait_fd;
 	uint64_t *memory_map_size;
 	struct lttng_ust_lib_ring_buffer *buf;
@@ -741,6 +741,7 @@ struct lttng_ust_lib_ring_buffer *ustctl_open_stream_read(struct lttng_ust_shm_h
 	if (!handle)
 		return NULL;
 
+	chan = handle->shadow_chan;
 	buf = channel_get_ring_buffer(&chan->backend.config,
 		chan, cpu, handle, &shm_fd, &wait_fd, &memory_map_size);
 	if (!buf)
@@ -784,11 +785,12 @@ int ustctl_get_mmap_len(struct lttng_ust_shm_handle *handle,
 		unsigned long *len)
 {
 	unsigned long mmap_buf_len;
-	struct channel *chan = handle->shadow_chan;
+	struct channel *chan;
 
 	if (!handle || !buf || !len)
 		return -EINVAL;
 
+	chan = handle->shadow_chan;
 	if (chan->backend.config.output != RING_BUFFER_MMAP)
 		return -EINVAL;
 	mmap_buf_len = chan->backend.buf_size;
@@ -805,11 +807,12 @@ int ustctl_get_max_subbuf_size(struct lttng_ust_shm_handle *handle,
 		struct lttng_ust_lib_ring_buffer *buf,
 		unsigned long *len)
 {
-	struct channel *chan = handle->shadow_chan;
+	struct channel *chan;
 
 	if (!handle || !buf || !len)
 		return -EINVAL;
 
+	chan = handle->shadow_chan;
 	*len = chan->backend.subbuf_size;
 	return 0;
 }
@@ -823,12 +826,13 @@ int ustctl_get_max_subbuf_size(struct lttng_ust_shm_handle *handle,
 int ustctl_get_mmap_read_offset(struct lttng_ust_shm_handle *handle,
 		struct lttng_ust_lib_ring_buffer *buf, unsigned long *off)
 {
-	struct channel *chan = handle->shadow_chan;
+	struct channel *chan;
 	unsigned long sb_bindex;
 
 	if (!handle || !buf || !off)
 		return -EINVAL;
 
+	chan = handle->shadow_chan;
 	if (chan->backend.config.output != RING_BUFFER_MMAP)
 		return -EINVAL;
 	sb_bindex = subbuffer_id_get_index(&chan->backend.config,
@@ -841,11 +845,12 @@ int ustctl_get_mmap_read_offset(struct lttng_ust_shm_handle *handle,
 int ustctl_get_subbuf_size(struct lttng_ust_shm_handle *handle,
 		struct lttng_ust_lib_ring_buffer *buf, unsigned long *len)
 {
-	struct channel *chan = handle->shadow_chan;
+	struct channel *chan;
 
 	if (!handle || !buf || !len)
 		return -EINVAL;
 
+	chan = handle->shadow_chan;
 	*len = lib_ring_buffer_get_read_data_size(&chan->backend.config, buf,
 		handle);
 	return 0;
@@ -855,11 +860,12 @@ int ustctl_get_subbuf_size(struct lttng_ust_shm_handle *handle,
 int ustctl_get_padded_subbuf_size(struct lttng_ust_shm_handle *handle,
 		struct lttng_ust_lib_ring_buffer *buf, unsigned long *len)
 {
-	struct channel *chan = handle->shadow_chan;
+	struct channel *chan;
 
 	if (!handle || !buf || !len)
 		return -EINVAL;
 
+	chan = handle->shadow_chan;
 	*len = lib_ring_buffer_get_read_data_size(&chan->backend.config, buf,
 		handle);
 	*len = PAGE_ALIGN(*len);

[lttng-dev] UST check pointer/de-reference order

[Mathieu Desnoyers]

* Oestman, Fredrik (Fredrik_Oestman at mentor.com) wrote:
> I stumbled across some code where pointers are de-referenced and then checked for NULL.
> 
> Cheers,

merged into master and stable-2.0, thanks!

Mathieu

> 
> Fredrik ?stman
> 
> 
> diff --git a/liblttng-ust-ctl/ustctl.c b/liblttng-ust-ctl/ustctl.c
> index 9789413..80aed04 100644
> --- a/liblttng-ust-ctl/ustctl.c
> +++ b/liblttng-ust-ctl/ustctl.c
> @@ -732,7 +732,7 @@ void ustctl_unmap_channel(struct lttng_ust_shm_handle *handle)
>  struct lttng_ust_lib_ring_buffer *ustctl_open_stream_read(struct lttng_ust_shm_handle *handle,
>  	int cpu)
>  {
> -	struct channel *chan = handle->shadow_chan;
> +	struct channel *chan;
>  	int *shm_fd, *wait_fd;
>  	uint64_t *memory_map_size;
>  	struct lttng_ust_lib_ring_buffer *buf;
> @@ -741,6 +741,7 @@ struct lttng_ust_lib_ring_buffer *ustctl_open_stream_read(struct lttng_ust_shm_h
>  	if (!handle)
>  		return NULL;
>  
> +	chan = handle->shadow_chan;
>  	buf = channel_get_ring_buffer(&chan->backend.config,
>  		chan, cpu, handle, &shm_fd, &wait_fd, &memory_map_size);
>  	if (!buf)
> @@ -784,11 +785,12 @@ int ustctl_get_mmap_len(struct lttng_ust_shm_handle *handle,
>  		unsigned long *len)
>  {
>  	unsigned long mmap_buf_len;
> -	struct channel *chan = handle->shadow_chan;
> +	struct channel *chan;
>  
>  	if (!handle || !buf || !len)
>  		return -EINVAL;
>  
> +	chan = handle->shadow_chan;
>  	if (chan->backend.config.output != RING_BUFFER_MMAP)
>  		return -EINVAL;
>  	mmap_buf_len = chan->backend.buf_size;
> @@ -805,11 +807,12 @@ int ustctl_get_max_subbuf_size(struct lttng_ust_shm_handle *handle,
>  		struct lttng_ust_lib_ring_buffer *buf,
>  		unsigned long *len)
>  {
> -	struct channel *chan = handle->shadow_chan;
> +	struct channel *chan;
>  
>  	if (!handle || !buf || !len)
>  		return -EINVAL;
>  
> +	chan = handle->shadow_chan;
>  	*len = chan->backend.subbuf_size;
>  	return 0;
>  }
> @@ -823,12 +826,13 @@ int ustctl_get_max_subbuf_size(struct lttng_ust_shm_handle *handle,
>  int ustctl_get_mmap_read_offset(struct lttng_ust_shm_handle *handle,
>  		struct lttng_ust_lib_ring_buffer *buf, unsigned long *off)
>  {
> -	struct channel *chan = handle->shadow_chan;
> +	struct channel *chan;
>  	unsigned long sb_bindex;
>  
>  	if (!handle || !buf || !off)
>  		return -EINVAL;
>  
> +	chan = handle->shadow_chan;
>  	if (chan->backend.config.output != RING_BUFFER_MMAP)
>  		return -EINVAL;
>  	sb_bindex = subbuffer_id_get_index(&chan->backend.config,
> @@ -841,11 +845,12 @@ int ustctl_get_mmap_read_offset(struct lttng_ust_shm_handle *handle,
>  int ustctl_get_subbuf_size(struct lttng_ust_shm_handle *handle,
>  		struct lttng_ust_lib_ring_buffer *buf, unsigned long *len)
>  {
> -	struct channel *chan = handle->shadow_chan;
> +	struct channel *chan;
>  
>  	if (!handle || !buf || !len)
>  		return -EINVAL;
>  
> +	chan = handle->shadow_chan;
>  	*len = lib_ring_buffer_get_read_data_size(&chan->backend.config, buf,
>  		handle);
>  	return 0;
> @@ -855,11 +860,12 @@ int ustctl_get_subbuf_size(struct lttng_ust_shm_handle *handle,
>  int ustctl_get_padded_subbuf_size(struct lttng_ust_shm_handle *handle,
>  		struct lttng_ust_lib_ring_buffer *buf, unsigned long *len)
>  {
> -	struct channel *chan = handle->shadow_chan;
> +	struct channel *chan;
>  
>  	if (!handle || !buf || !len)
>  		return -EINVAL;
>  
> +	chan = handle->shadow_chan;
>  	*len = lib_ring_buffer_get_read_data_size(&chan->backend.config, buf,
>  		handle);
>  	*len = PAGE_ALIGN(*len);
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com

[lttng-dev] Displaying graphical results

[Francis Giraldeau]

Le 2012-06-04 22:57, tchak adim a ?crit :
> for Eclipse tool :
> i already follow the different steps to integrate the cft, lttng2
> plugins as described in the link that u give it .
> i don't konw how can i visualize the graphics of lttng kernel module
> traces using eclipse , can u explain to me how ?

You need to select the lttng perspective, then create an lttng project,
import a trace trace and then it should show up. There are multiple
views, the event view displays events in a table, and the control flow
view shows process states according to time.

Cheers,

Francis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4476 bytes
Desc: Signature cryptographique S/MIME
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120605/5a5206d6/attachment-0001.bin>

[lttng-dev] Displaying graphical results

[Bernd Hufmann]

Hi

We are currently finalizing the LTTng 2.0 Integration in Eclipse as part 
of the Eclipse Juno release.

As I understood you are using the source code of Eclipse LTTng 2.0 
integration. After starting the Eclipse application, switch to the 
perspective "LTTng Kernel". By default the following views will show:

  * Project Explorer
    This view is for handling Tracing projects, traces and experiments.
    To start viewing a trace, use the New Project wizard of Eclipse to
    create "Tracing Project".  (Right mouse click in Project Explorer
    view -> New - Tracing Project). Then import a trace to the "Traces"
    sub-folder of you newly created project. (Right mouse click on
    folder "Traces"). You could also drag-&-drop a trace to the "Traces"
    sub-folder. Note that you need to select the the trace type during
    import (not drag&drop) or afterwards by using the context-sensitive
    menu on the trace (Right mouse-click on the trace -> Click on
    "Select Trace Type..." -> Common Trace Format -> Kernel Trace).
    After that you can open the trace.
  * Control
    This view is to create traces remotely using an SSH connection to a
    remote (or local) host. This if you want to create a session,
    enable/disable events or channels, start and stop tracing. You also
    can import create trace to your workspace
  * Events View
    This view contains a table displaying each event in a table form.
     From the top row you can search or filter events
  * Control Flow View
    This view shows the kernel control flow (process states over time).
    It uses internally a persistent state system which is create when
    you open the trace the first time. In this view you can zoom using
    cool bar buttons or mouse wheel. You can step from one event to the
    next/previous event per process using the relevant buttons.
  * Resources View
    This view shows you system resources such as CPUs, IRQs, Soft IRQs
    and their states over time. This view also uses the persistent state
    system I mentioned above. The buttons, zooming behaviour etc. are
    same as for the Control Flow View
  * Histogram View
    This view shows the event density (number of events over time). The
    big window shows the whole trace. The same one shows the current
    selected time range.
  * Statistics View
    This view shows you the total number events and number of events per
    event time of the whole trace
  * Bookmarks view
    Using the context-sensitive menu of the Events table you can
    bookmark events. In the bookmark view you can double-click on a
    bookmark and the event will be shown in the events table as well as
    in all other open LTTng views.

All views are synchronized. That means when selecting an event one of 
the view, it will  be shown also in the other views. Additionally, when 
changing the active time range (e.g. in the Histogram View), also the 
Control Flow View/Resources View will show the new time range.

This was a brief introduction into what is coming up for the LTTng Juno. 
Keep in mind, that there might be still some bugs, so I apologizes for 
any glitches you may experience. These glitches will be fixed, as well 
as a comprehensive User Guide will be available for the Juno release.

Best Regards
Bernd

On 06/05/2012 05:27 AM, Francis Giraldeau wrote:
> Le 2012-06-04 22:57, tchak adim a ?crit :
>> for Eclipse tool :
>> i already follow the different steps to integrate the cft, lttng2
>> plugins as described in the link that u give it .
>> i don't konw how can i visualize the graphics of lttng kernel module
>> traces using eclipse , can u explain to me how ?
> You need to select the lttng perspective, then create an lttng project,
> import a trace trace and then it should show up. There are multiple
> views, the event view displays events in a table, and the control flow
> view shows process states according to time.
>
> Cheers,
>
> Francis
>



On 06/04/2012 04:57 PM, tchak adim wrote:
> for Eclipse tool :
> i already follow the different steps to integrate the cft, lttng2 
> plugins as described in the link that u give it .
> i don't konw how can i visualize the graphics of lttng kernel module 
> traces using eclipse , can u explain to me how ?
>
> For sourcery tool :
> i didn't find the source code, i'm using an ordinary i386 machine 
> running ubuntu 10.04.
>
> Can u advice me and tell me what i can do ?
>
> thanks in advance !

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120605/f3191f9f/attachment.html>

[lttng-dev] Displaying graphical results

[tchak adim]

Thanks for all for your detailed responses .

Regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120605/c503f31c/attachment.html>

[lttng-dev] Displaying graphical results

[Brosseau, Yannick]

>
> Support in LTTV (the other, more lightweight viewer) should be just
> around the corner.

Just to add that we currently have the textDump working in LTTV and
we've just got the main GUI window working. We should be able to get
the views really soon now.

Yannick

[lttng-dev] Displaying graphical results

[tchak adim]

Good news ..
That make things much better :)

Thanks for the information.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120605/15908781/attachment.html>