Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
* [lttng-dev] [PATCH lttng-tools] Fix: set UST register timeout to -1 as test default
@ 2015-04-28 14:16 Mathieu Desnoyers
  2015-04-29 15:12 ` Jérémie Galarneau
  0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Desnoyers @ 2015-04-28 14:16 UTC (permalink / raw)


On busy systems, it's possible to spuriously hit the default 3 seconds
timeout for UST registration to sessiond, thus causing tests to be flaky
on those systems.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
---
 tests/utils/utils.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh
index c3d8bd4..5f86ece 100644
--- a/tests/utils/utils.sh
+++ b/tests/utils/utils.sh
@@ -27,6 +27,11 @@ KERNEL_MAJOR_VERSION=2
 KERNEL_MINOR_VERSION=6
 KERNEL_PATCHLEVEL_VERSION=27
 
+# We set the default UST register timeout to "wait forever", so that
+# basic tests don't have to worry about hitting timeouts on busy
+# systems. Specialized tests should test those corner-cases.
+export LTTNG_UST_REGISTER_TIMEOUT=-1
+
 source $TESTDIR/utils/tap/tap.sh
 
 function print_ok ()
-- 
2.1.4




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [lttng-dev] [PATCH lttng-tools] Fix: set UST register timeout to -1 as test default
  2015-04-28 14:16 [lttng-dev] [PATCH lttng-tools] Fix: set UST register timeout to -1 as test default Mathieu Desnoyers
@ 2015-04-29 15:12 ` Jérémie Galarneau
  0 siblings, 0 replies; 2+ messages in thread
From: Jérémie Galarneau @ 2015-04-29 15:12 UTC (permalink / raw)


Merged in master, 2.6 and 2.5.

Thanks!
J?r?mie

On Tue, Apr 28, 2015 at 10:16 AM, Mathieu Desnoyers <
mathieu.desnoyers at efficios.com> wrote:

> On busy systems, it's possible to spuriously hit the default 3 seconds
> timeout for UST registration to sessiond, thus causing tests to be flaky
> on those systems.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
>  tests/utils/utils.sh | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh
> index c3d8bd4..5f86ece 100644
> --- a/tests/utils/utils.sh
> +++ b/tests/utils/utils.sh
> @@ -27,6 +27,11 @@ KERNEL_MAJOR_VERSION=2
>  KERNEL_MINOR_VERSION=6
>  KERNEL_PATCHLEVEL_VERSION=27
>
> +# We set the default UST register timeout to "wait forever", so that
> +# basic tests don't have to worry about hitting timeouts on busy
> +# systems. Specialized tests should test those corner-cases.
> +export LTTNG_UST_REGISTER_TIMEOUT=-1
> +
>  source $TESTDIR/utils/tap/tap.sh
>
>  function print_ok ()
> --
> 2.1.4
>
>


-- 
J?r?mie Galarneau
EfficiOS Inc.
http://www.efficios.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20150429/767a7610/attachment.html>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-29 15:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-28 14:16 [lttng-dev] [PATCH lttng-tools] Fix: set UST register timeout to -1 as test default Mathieu Desnoyers
2015-04-29 15:12 ` Jérémie Galarneau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox