[lttng-dev] [PATCH lttng-tools] Fix: pointer dereference after NULL check in test_create_ust_event_exclusion

[lttng-dev] [PATCH lttng-tools] Fix: pointer dereference after NULL check in test_create_ust_event_exclusion

[Jérémie Galarneau]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

Merged, thanks!

I also skipped the rest of the test since we'd be using a NULL "exclusion".

Jérémie

On Tue, May 17, 2016 at 10:48 AM, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> CID 1256182 (#2 of 2): Dereference after null check (FORWARD_NULL)16.
> var_deref_op: Dereferencing null pointer exclusion.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
>  tests/unit/test_ust_data.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/unit/test_ust_data.c b/tests/unit/test_ust_data.c
> index d811695..236f507 100644
> --- a/tests/unit/test_ust_data.c
> +++ b/tests/unit/test_ust_data.c
> @@ -38,7 +38,7 @@
>  #define RANDOM_STRING_LEN      11
>
>  /* Number of TAP tests in this file */
> -#define NUM_TESTS 15
> +#define NUM_TESTS 16
>
>  /* For error.h */
>  int lttng_opt_quiet = 1;
> @@ -188,6 +188,8 @@ static void test_create_ust_event_exclusion(void)
>                 PERROR("zmalloc");
>         }
>
> +       ok(exclusion != NULL, "Create UST exclusion");
> +
>         exclusion->count = exclusion_count;
>         strncpy(LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion, 0),
>                 get_random_string(), LTTNG_SYMBOL_NAME_LEN);
> --
> 2.1.4
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com