From: jeremie.galarneau@efficios.com (Jérémie Galarneau)
Subject: [lttng-dev] [PATCH babeltrace] Fix: glib >= 2.32 required for g_hash_table_contains() in lib/values.c
Date: Mon, 21 Sep 2015 17:15:59 -0400 [thread overview]
Message-ID: <CA+jJMxtE38xCqs_XZaMCErKsn4Li2MgNkceouBHXUn+aRSp__w@mail.gmail.com> (raw)
In-Reply-To: <1442868519-22000-1-git-send-email-mjeanson@efficios.com>
We could change the uses of g_hash_table_contains() to use
g_hash_table_find() (which was present in 2.4).
However, at this point I wouldn't feel too bad bumping the dependency
to 2.32 in BT 2.0 considering glib 2.32 was released in March 2012 and
was, AFAICT, shipped in Ubuntu 12.04... No strong opinion.
Mathieu, thoughts?
J?r?mie
On Mon, Sep 21, 2015 at 4:48 PM, Michael Jeanson <mjeanson at efficios.com> wrote:
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index dc23daa..a815274 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -54,7 +54,7 @@ if test ! -f "$srcdir/formats/ctf/metadata/ctf-lexer.c"; then
> fi
>
>
> -AM_PATH_GLIB_2_0(2.22.0, ,AC_MSG_ERROR([glib is required in order to compile BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule)
> +AM_PATH_GLIB_2_0(2.32.0, ,AC_MSG_ERROR([glib is required in order to compile BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule)
>
> # Checks for typedefs, structures, and compiler characteristics.
> AC_C_INLINE
> --
> 1.9.1
>
--
J?r?mie Galarneau
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2015-09-21 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 20:48 Michael Jeanson
2015-09-21 21:15 ` Jérémie Galarneau [this message]
2015-09-21 21:42 ` Mathieu Desnoyers
2015-09-21 21:43 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+jJMxtE38xCqs_XZaMCErKsn4Li2MgNkceouBHXUn+aRSp__w@mail.gmail.com \
--to=jeremie.galarneau@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox