[lttng-dev] [PATCH babeltrace] Fix: glib >= 2.32 required for g_hash_table_contains() in lib/values.c

[mathieu.desnoyers@efficios.com (Mathieu Desnoyers)]

----- On Sep 21, 2015, at 5:15 PM, Jeremie Galarneau jeremie.galarneau at efficios.com wrote:

> We could change the uses of g_hash_table_contains() to use
> g_hash_table_find() (which was present in 2.4).
> 
> However, at this point I wouldn't feel too bad bumping the dependency
> to 2.32 in BT 2.0 considering glib 2.32 was released in March 2012 and
> was, AFAICT, shipped in Ubuntu 12.04... No strong opinion.
> 
> Mathieu, thoughts?

SLES 11 SP3 has 2.22.5:

https://www.suse.com/LinuxPackages/packageRouter.jsp?product=desktop&version=11&service_pack=sp3&architecture=i386&package_name=glib2-devel

I'd keep the current old dep if possible.

Thanks,

Mathieu

> 
> J?r?mie
> 
> On Mon, Sep 21, 2015 at 4:48 PM, Michael Jeanson <mjeanson at efficios.com> wrote:
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index dc23daa..a815274 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -54,7 +54,7 @@ if test ! -f "$srcdir/formats/ctf/metadata/ctf-lexer.c"; then
>>  fi
>>
>>
>> -AM_PATH_GLIB_2_0(2.22.0, ,AC_MSG_ERROR([glib is required in order to compile
>> BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule)
>> +AM_PATH_GLIB_2_0(2.32.0, ,AC_MSG_ERROR([glib is required in order to compile
>> BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule)
>>
>>  # Checks for typedefs, structures, and compiler characteristics.
>>  AC_C_INLINE
>> --
>> 1.9.1
>>
> 
> 
> 
> --
> J?r?mie Galarneau
> EfficiOS Inc.
> http://www.efficios.com

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com