[lttng-dev] [PATCH lttng-tools] Fix: NULL pointer dereference in relay_index_get_by_id_or_create

[lttng-dev] [PATCH lttng-tools] Fix: NULL pointer dereference in relay_index_get_by_id_or_create

[Jérémie Galarneau]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Merged, thanks!

Jérémie

On Tue, May 17, 2016 at 10:44 AM, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> Found by Coverity:
>
> CID 1323134 (#1 of 1): Dereference after null check (FORWARD_NULL)34.
> var_deref_op: Dereferencing null pointer index.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
>  src/bin/lttng-relayd/index.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bin/lttng-relayd/index.c b/src/bin/lttng-relayd/index.c
> index 9c30779..80a4bb9 100644
> --- a/src/bin/lttng-relayd/index.c
> +++ b/src/bin/lttng-relayd/index.c
> @@ -162,7 +162,7 @@ struct relay_index *relay_index_get_by_id_or_create(struct relay_stream *stream,
>  end:
>         rcu_read_unlock();
>         DBG2("Index %sfound or created in HT for stream ID %" PRIu64 " and seqnum %" PRIu64,
> -                       (index == NULL) ? "NOT " : "", index->stream->stream_handle, net_seq_num);
> +                       (index == NULL) ? "NOT " : "", stream->stream_handle, net_seq_num);
>         return index;
>  }
>
> --
> 2.1.4
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com