* [lttng-dev] [PATCH lttng-tools] Fix: Wrong sizeof argument in pid tracker
[not found] <1463491430-21099-1-git-send-email-mathieu.desnoyers@efficios.com>
@ 2016-05-18 18:24 ` Jérémie Galarneau
0 siblings, 0 replies; only message in thread
From: Jérémie Galarneau @ 2016-05-18 18:24 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]
Merged, thanks!
Jérémie
On Tue, May 17, 2016 at 9:23 AM, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> Found by Coverity:
>
> CID 1292557 (#1 of 1): Wrong sizeof argument
> (SIZEOF_MISMATCH)suspicious_sizeof: Passing argument 8UL /* sizeof
> (*_pid_list) */ to function zmalloc and then casting the return value to
> int * is suspicious.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
> src/bin/lttng/commands/track-untrack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bin/lttng/commands/track-untrack.c b/src/bin/lttng/commands/track-untrack.c
> index 3771de5..d9e18c1 100644
> --- a/src/bin/lttng/commands/track-untrack.c
> +++ b/src/bin/lttng/commands/track-untrack.c
> @@ -87,7 +87,7 @@ int parse_pid_string(const char *_pid_string,
> goto error;
> }
> if (all) {
> - pid_list = zmalloc(sizeof(*_pid_list));
> + pid_list = zmalloc(sizeof(*pid_list));
> if (!pid_list) {
> ERR("Out of memory");
> retval = CMD_ERROR;
> --
> 2.1.4
>
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] only message in thread