* [ltt-dev] [PATCH] urcu_ref: do error checking on urcu_ref_put
@ 2011-06-09 13:57 Paolo Bonzini
2011-06-09 14:14 ` Mathieu Desnoyers
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2011-06-09 13:57 UTC (permalink / raw)
Underflow is what you really want to trap. When you reach urcu_ref_get, it
is already too late.
Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
---
urcu/urcu_ref.h | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/urcu/urcu_ref.h b/urcu/urcu_ref.h
index bce7116..06b81b9 100644
--- a/urcu/urcu_ref.h
+++ b/urcu/urcu_ref.h
@@ -33,14 +33,15 @@ static inline void urcu_ref_init(struct urcu_ref *ref)
static inline void urcu_ref_get(struct urcu_ref *ref)
{
- long res = uatomic_add_return(&ref->refcount, 1);
- assert(res != 0);
+ uatomic_add(&ref->refcount, 1);
}
static inline void urcu_ref_put(struct urcu_ref *ref,
void (*release)(struct urcu_ref *))
{
- if (!uatomic_sub_return(&ref->refcount, 1))
+ long res = uatomic_sub_return(&ref->refcount, 1);
+ assert (res >= 0);
+ if (res == 0)
release(ref);
}
--
1.7.4.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [ltt-dev] [PATCH] urcu_ref: do error checking on urcu_ref_put
2011-06-09 13:57 [ltt-dev] [PATCH] urcu_ref: do error checking on urcu_ref_put Paolo Bonzini
@ 2011-06-09 14:14 ` Mathieu Desnoyers
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Desnoyers @ 2011-06-09 14:14 UTC (permalink / raw)
* Paolo Bonzini (pbonzini at redhat.com) wrote:
> Underflow is what you really want to trap. When you reach urcu_ref_get, it
> is already too late.
Merged, thanks!
Mathieu
>
> Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
> ---
> urcu/urcu_ref.h | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/urcu/urcu_ref.h b/urcu/urcu_ref.h
> index bce7116..06b81b9 100644
> --- a/urcu/urcu_ref.h
> +++ b/urcu/urcu_ref.h
> @@ -33,14 +33,15 @@ static inline void urcu_ref_init(struct urcu_ref *ref)
>
> static inline void urcu_ref_get(struct urcu_ref *ref)
> {
> - long res = uatomic_add_return(&ref->refcount, 1);
> - assert(res != 0);
> + uatomic_add(&ref->refcount, 1);
> }
>
> static inline void urcu_ref_put(struct urcu_ref *ref,
> void (*release)(struct urcu_ref *))
> {
> - if (!uatomic_sub_return(&ref->refcount, 1))
> + long res = uatomic_sub_return(&ref->refcount, 1);
> + assert (res >= 0);
> + if (res == 0)
> release(ref);
> }
>
> --
> 1.7.4.4
>
>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-09 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-09 13:57 [ltt-dev] [PATCH] urcu_ref: do error checking on urcu_ref_put Paolo Bonzini
2011-06-09 14:14 ` Mathieu Desnoyers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox