[ltt-dev] [PATCH] arm: remove useless declarations

[compudj@krystal.dyndns.org (Mathieu Desnoyers)]

* Paolo Bonzini (pbonzini at redhat.com) wrote:
> Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
> ---
>  urcu/uatomic_arch_arm.h |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/urcu/uatomic_arch_arm.h b/urcu/uatomic_arch_arm.h
> index bcd21d2..fee3040 100644
> --- a/urcu/uatomic_arch_arm.h
> +++ b/urcu/uatomic_arch_arm.h
> @@ -34,13 +34,6 @@ extern "C" {
>  /* xchg */
>  #define uatomic_xchg(addr, v) __sync_lock_test_and_set(addr, v)
>  
> -/* cmpxchg */
> -#define uatomic_cmpxchg(addr, old, _new) \
> -	__sync_val_compare_and_swap(addr, old, _new)
> -
> -/* uatomic_add_return */
> -#define uatomic_add_return(addr, v) __sync_add_and_fetch(addr, v)

I'd first like to understand why Paul chose to override the generic
versions of these macros. There is a change in what you map to:

__sync_val_compare_and_swap -> __sync_val_compare_and_swap_1/2/4/8

__sync_add_and_fetch -> __sync_add_and_fetch_1/2/4/8

Were there any problems with the _N variants on some ARM compilers ?

Thanks,

Mathieu

> -
>  #ifdef __cplusplus 
>  }
>  #endif
> -- 
> 1.7.4.4
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com