Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: paulmck@linux.vnet.ibm.com (Paul E. McKenney)
Subject: [ltt-dev] [PATCH] arm: remove useless declarations
Date: Thu, 9 Jun 2011 09:43:08 -0700	[thread overview]
Message-ID: <20110609164307.GE2285@linux.vnet.ibm.com> (raw)
In-Reply-To: <4DF0D7E8.106@redhat.com>

On Thu, Jun 09, 2011 at 04:25:44PM +0200, Paolo Bonzini wrote:
> On 06/09/2011 04:21 PM, Mathieu Desnoyers wrote:
> >I'd first like to understand why Paul chose to override the generic
> >versions of these macros. There is a change in what you map to:
> >
> >__sync_val_compare_and_swap ->  __sync_val_compare_and_swap_1/2/4/8
> >
> >__sync_add_and_fetch ->  __sync_add_and_fetch_1/2/4/8
> >
> >Were there any problems with the _N variants on some ARM compilers ?
> 
> The non-"_N" variants do not exist outside the back-end (they are
> mapped to the "_N" variants by target-independent parts of the
> compiler), but I agree that Paul's ack is good to have.

In some of the older versions of ARM Linux and toolchain, many of which
are unfortunately still in heavy use, the __sync_synchronize() primitive
was broken (as in was a no-op), but from what I can see the others worked
just fine.

							Thanx, Paul



  reply	other threads:[~2011-06-09 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09 13:57 Paolo Bonzini
2011-06-09 14:21 ` Mathieu Desnoyers
     [not found] ` <BLU0-SMTP84C8B5894BECC3A6D9BB7C96650@phx.gbl>
2011-06-09 14:25   ` Paolo Bonzini
2011-06-09 16:43     ` Paul E. McKenney [this message]
2011-06-09 16:50       ` Mathieu Desnoyers
     [not found]       ` <BLU0-SMTP515252C09A7991113F85D96650@phx.gbl>
2011-06-09 17:17         ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110609164307.GE2285@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox