[lttng-dev] UST context field "ip" is now in decimal since 2.13 instead of hexadecimal as before

[lttng-dev] UST context field "ip" is now in decimal since 2.13 instead of hexadecimal as before

[thomas.gatterweh--- via lttng-dev]

[-- Attachment #1.1: Type: text/plain, Size: 477 bytes --]

Hi!

In this commit  https://github.com/lttng/lttng-ust/commit/4e48b5d2debaf6c0c598489c183cc6cb2125c8a3  the base for UST context field "ip" was changed from 16 (hexadecimal) to 10 (decimal), most likely an unintentional copy&paste error. See change in lttng-context-ip.c, line 47.
Can it be changed back to 16 (hexadecimal), so that the ip address recorded by this context field gets displayed in hex again, which makes much more sense?

Best regards,
Thomas Gatterweh

[-- Attachment #1.2: Type: text/html, Size: 2511 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [lttng-dev] UST context field "ip" is now in decimal since 2.13 instead of hexadecimal as before

[Jérémie Galarneau via lttng-dev]

[-- Attachment #1.1: Type: text/plain, Size: 1039 bytes --]

Hi Thomas,

I have submitted a patch on our gerrit, see:
https://review.lttng.org/c/lttng-ust/+/9659

Thanks for the report!
Jérémie

--
Jérémie Galarneau
EfficiOS Inc.
https://www.efficios.com
________________________________
From: lttng-dev <lttng-dev-bounces@lists.lttng.org> on behalf of thomas.gatterweh--- via lttng-dev <lttng-dev@lists.lttng.org>
Sent: March 14, 2023 05:03
To: lttng-dev <lttng-dev@lists.lttng.org>
Subject: [lttng-dev] UST context field "ip" is now in decimal since 2.13 instead of hexadecimal as before


Hi!



In this commit  https://github.com/lttng/lttng-ust/commit/4e48b5d2debaf6c0c598489c183cc6cb2125c8a3  the base for UST context field “ip” was changed from 16 (hexadecimal) to 10 (decimal), most likely an unintentional copy&paste error. See change in lttng-context-ip.c, line 47.

Can it be changed back to 16 (hexadecimal), so that the ip address recorded by this context field gets displayed in hex again, which makes much more sense?



Best regards,

Thomas Gatterweh

[-- Attachment #1.2: Type: text/html, Size: 4526 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev