Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: jeromezhr@gmail.com (jerome zh)
Subject: [ltt-dev] Cannot destroy trace
Date: Tue, 11 May 2010 20:07:14 +0800	[thread overview]
Message-ID: <AANLkTikXyfYCixckE_XX2yi-0OMeYYTGIwF1HVCxymfm@mail.gmail.com> (raw)
In-Reply-To: <20100511120011.GB17304@Krystal>

2010/5/11 Mathieu Desnoyers <compudj at krystal.dyndns.org>

> * jerome zh (jeromezhr at gmail.com) wrote:
> > Hi all,
> >
> > I have modified the original lttng kernel patch to fit my RT-linux
> patched
> > 2.6.30 kernel. And IMHO the kernel now works fine.
> > Everything seems OK until I run "lttctl -D trace1", the process became
> > "blocking like"(I am not sure if it is blocked).
> > The last msg printed on the screen is "lttctl: Destroying trace".
> > Then I added some debug message into the liblttctl.c file. As a result,
> the
> > process was "blocked" while executing
> > *write(fd, op, strlen(op))* in function *lttctl_sendop()*.
> >
> > Any advice? Thanks in advance.
>
> Can you try with the following patch ?
>
>
> lttng fix rt kernel teardown deadlock
>
> LTTng has a teardown bug on RT (deadlock):
>
> Deleting a timer (sync) while holding the traces mutex, and the handler
> takes
> the same mutex, which leads to a deadlock.
>
> Fix this by taking a RCU read lock in the timer (instead of the RT-specific
> fix
> using the mutex), and by doing synchronize_rcu() in addition to
> synchronize_sched() upon updates.
>
> ---
>


>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
>


Thanks!
I will try this patch and let you know if it works on my board.

-- 
Regards,

Jerome
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20100511/ac949fb3/attachment-0002.htm>


WARNING: multiple messages have this Message-ID
From: jeromezhr@gmail.com (jerome zh)
Subject: [ltt-dev] Cannot destroy trace
Date: Tue, 11 May 2010 20:07:14 +0800	[thread overview]
Message-ID: <AANLkTikXyfYCixckE_XX2yi-0OMeYYTGIwF1HVCxymfm@mail.gmail.com> (raw)
Message-ID: <20100511120714.OuOmse1DCI_m1V6qSK3AnleDWu-2gdl8ZBmCmejuUA0@z> (raw)
In-Reply-To: <20100511120011.GB17304@Krystal>

2010/5/11 Mathieu Desnoyers <compudj at krystal.dyndns.org>

> * jerome zh (jeromezhr at gmail.com) wrote:
> > Hi all,
> >
> > I have modified the original lttng kernel patch to fit my RT-linux
> patched
> > 2.6.30 kernel. And IMHO the kernel now works fine.
> > Everything seems OK until I run "lttctl -D trace1", the process became
> > "blocking like"(I am not sure if it is blocked).
> > The last msg printed on the screen is "lttctl: Destroying trace".
> > Then I added some debug message into the liblttctl.c file. As a result,
> the
> > process was "blocked" while executing
> > *write(fd, op, strlen(op))* in function *lttctl_sendop()*.
> >
> > Any advice? Thanks in advance.
>
> Can you try with the following patch ?
>
>
> lttng fix rt kernel teardown deadlock
>
> LTTng has a teardown bug on RT (deadlock):
>
> Deleting a timer (sync) while holding the traces mutex, and the handler
> takes
> the same mutex, which leads to a deadlock.
>
> Fix this by taking a RCU read lock in the timer (instead of the RT-specific
> fix
> using the mutex), and by doing synchronize_rcu() in addition to
> synchronize_sched() upon updates.
>
> ---
>


>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
>


Thanks!
I will try this patch and let you know if it works on my board.

-- 
Regards,

Jerome
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20100511/ac949fb3/attachment-0003.htm>


WARNING: multiple messages have this Message-ID
From: jeromezhr@gmail.com (jerome zh)
Subject: [ltt-dev] Cannot destroy trace
Date: Tue, 11 May 2010 20:07:14 +0800	[thread overview]
Message-ID: <AANLkTikXyfYCixckE_XX2yi-0OMeYYTGIwF1HVCxymfm@mail.gmail.com> (raw)
Message-ID: <20100511120714.b3uEGvi5DWx7mwbZF49aNReLvcTYcTkDh7FXndDfHPE@z> (raw)
In-Reply-To: <20100511120011.GB17304@Krystal>

2010/5/11 Mathieu Desnoyers <compudj at krystal.dyndns.org>

> * jerome zh (jeromezhr at gmail.com) wrote:
> > Hi all,
> >
> > I have modified the original lttng kernel patch to fit my RT-linux
> patched
> > 2.6.30 kernel. And IMHO the kernel now works fine.
> > Everything seems OK until I run "lttctl -D trace1", the process became
> > "blocking like"(I am not sure if it is blocked).
> > The last msg printed on the screen is "lttctl: Destroying trace".
> > Then I added some debug message into the liblttctl.c file. As a result,
> the
> > process was "blocked" while executing
> > *write(fd, op, strlen(op))* in function *lttctl_sendop()*.
> >
> > Any advice? Thanks in advance.
>
> Can you try with the following patch ?
>
>
> lttng fix rt kernel teardown deadlock
>
> LTTng has a teardown bug on RT (deadlock):
>
> Deleting a timer (sync) while holding the traces mutex, and the handler
> takes
> the same mutex, which leads to a deadlock.
>
> Fix this by taking a RCU read lock in the timer (instead of the RT-specific
> fix
> using the mutex), and by doing synchronize_rcu() in addition to
> synchronize_sched() upon updates.
>
> ---
>


>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
>


Thanks!
I will try this patch and let you know if it works on my board.

-- 
Regards,

Jerome
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.casi.polymtl.ca/pipermail/ltt-dev/attachments/20100511/ac949fb3/attachment-0001.htm>


  reply	other threads:[~2010-05-11 12:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 14:51 jerome zh
2010-05-05 14:51 ` jerome zh
2010-05-05 14:51 ` jerome zh
2010-05-11 12:00 ` Mathieu Desnoyers
2010-05-11 12:07   ` jerome zh [this message]
2010-05-11 12:07     ` jerome zh
2010-05-11 12:07     ` jerome zh
2010-05-14 13:27     ` jerome zh
2010-05-14 13:27       ` jerome zh
2010-05-14 13:27       ` jerome zh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikXyfYCixckE_XX2yi-0OMeYYTGIwF1HVCxymfm@mail.gmail.com \
    --to=jeromezhr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox