From: laijs@cn.fujitsu.com (Lai Jiangshan)
Subject: [ltt-dev] [PATCH 5/9] use random value for hash value directly
Date: Wed, 16 Nov 2011 16:41:53 +0800 [thread overview]
Message-ID: <4EC37751.8060907@cn.fujitsu.com> (raw)
In-Reply-To: <20111115112002.GD16701@Krystal>
On 11/15/2011 07:20 PM, Mathieu Desnoyers wrote:
> * Lai Jiangshan (laijs at cn.fujitsu.com) wrote:
> [...]
>> struct lfht_test_node {
>> struct cds_lfht_node node;
>> - void *key;
>> - unsigned int key_len;
>> + unsigned long hash;
>> /* cache-cold for iteration */
>> struct rcu_head head;
>
> I'm really unsure about this.
The key is just a black box for a hash table.
hash table focus on hash value mainly, so we can use random value for
hash value when testing if the random values are good(very random).
> One of the test-case should be to walk
> through identical-hash-value-chain and find the right node by matching
> its key. If we make the hash equal to the key, we don't test the "match"
> code anymore.
>
there is no duplicated key/node for this patch.
next prev parent reply other threads:[~2011-11-16 8:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 4:50 [ltt-dev] [PATCH 0/9] change lfht test Lai Jiangshan
2011-11-14 4:50 ` [ltt-dev] [PATCH 1/9] Fix arguments order Lai Jiangshan
2011-11-14 12:57 ` Mathieu Desnoyers
2011-11-14 4:50 ` [ltt-dev] [PATCH 2/9] keep the last position for failed lookup Lai Jiangshan
2011-11-15 11:10 ` Mathieu Desnoyers
2011-11-16 8:33 ` Lai Jiangshan
2011-11-14 4:50 ` [ltt-dev] [PATCH 3/9] add cds_lfht_add_at() Lai Jiangshan
2011-11-15 8:23 ` Lai Jiangshan
2011-11-15 11:07 ` Mathieu Desnoyers
2011-11-18 14:29 ` Mathieu Desnoyers
2011-11-21 3:15 ` Lai Jiangshan
2011-11-22 9:41 ` Mathieu Desnoyers
2011-11-14 4:50 ` [ltt-dev] [PATCH 4/9] new random generator Lai Jiangshan
2011-11-15 11:17 ` Mathieu Desnoyers
2011-11-14 4:50 ` [ltt-dev] [PATCH 5/9] use random value for hash value directly Lai Jiangshan
2011-11-15 11:20 ` Mathieu Desnoyers
2011-11-16 8:41 ` Lai Jiangshan [this message]
2011-11-14 4:50 ` [ltt-dev] [PATCH 6/9] test hash value Confilict with buckets Lai Jiangshan
2011-11-15 11:22 ` Mathieu Desnoyers
2011-11-16 8:53 ` Lai Jiangshan
2011-11-14 4:50 ` [ltt-dev] [PATCH 7/9] add identical-hash-value-chain test Lai Jiangshan
2011-11-15 11:24 ` Mathieu Desnoyers
2011-11-16 8:55 ` Lai Jiangshan
2011-11-14 4:50 ` [ltt-dev] [PATCH 8/9] add duplicated node test Lai Jiangshan
2011-11-15 11:31 ` Mathieu Desnoyers
2011-11-16 9:16 ` Lai Jiangshan
2011-11-14 4:50 ` [ltt-dev] [PATCH 9/9] change strategy for AR_RANDOM Lai Jiangshan
2011-11-15 11:35 ` Mathieu Desnoyers
2011-11-16 9:26 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC37751.8060907@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox