From mboxrd@z Thu Jan 1 00:00:00 1970 From: laijs@cn.fujitsu.com (Lai Jiangshan) Date: Wed, 16 Nov 2011 16:41:53 +0800 Subject: [ltt-dev] [PATCH 5/9] use random value for hash value directly In-Reply-To: <20111115112002.GD16701@Krystal> References: <1321246259-21223-1-git-send-email-laijs@cn.fujitsu.com> <1321246259-21223-6-git-send-email-laijs@cn.fujitsu.com> <20111115112002.GD16701@Krystal> Message-ID: <4EC37751.8060907@cn.fujitsu.com> On 11/15/2011 07:20 PM, Mathieu Desnoyers wrote: > * Lai Jiangshan (laijs at cn.fujitsu.com) wrote: > [...] >> struct lfht_test_node { >> struct cds_lfht_node node; >> - void *key; >> - unsigned int key_len; >> + unsigned long hash; >> /* cache-cold for iteration */ >> struct rcu_head head; > > I'm really unsure about this. The key is just a black box for a hash table. hash table focus on hash value mainly, so we can use random value for hash value when testing if the random values are good(very random). > One of the test-case should be to walk > through identical-hash-value-chain and find the right node by matching > its key. If we make the hash equal to the key, we don't test the "match" > code anymore. > there is no duplicated key/node for this patch.