* [ltt-dev] [UST PATCH 1/3] Kill some unused code in ustcomm.c
@ 2010-11-09 15:31 David Goulet
2010-11-09 15:57 ` Nils Carlson
0 siblings, 1 reply; 3+ messages in thread
From: David Goulet @ 2010-11-09 15:31 UTC (permalink / raw)
Maybe also get rid of the definition in libustcomm/ustcomm.h :)
Acked-by: David Goulet <david.goulet at polymtl.ca>
On 10-11-04 12:54 PM, Nils Carlson wrote:
>
> Signed-off-by: Nils Carlson<nils.carlson at ericsson.com>
> ---
> libustcomm/ustcomm.c | 49 -------------------------------------------------
> 1 files changed, 0 insertions(+), 49 deletions(-)
>
> diff --git a/libustcomm/ustcomm.c b/libustcomm/ustcomm.c
> index 2c547ab..fe8fea2 100644
> --- a/libustcomm/ustcomm.c
> +++ b/libustcomm/ustcomm.c
> @@ -775,52 +775,3 @@ int ustcomm_unpack_sock_path(struct ustcomm_sock_path *sock_path_inf)
> return 0;
> }
>
> -int ustcomm_send_ch_req(int sock, char *channel, int command,
> - struct ustcomm_header *recv_header,
> - char *recv_data)
> -{
> - struct ustcomm_header send_header;
> - struct ustcomm_channel_info ch_info;
> - int result;
> -
> - result = ustcomm_pack_channel_info(&send_header,
> - &ch_info,
> - channel);
> - if (result< 0) {
> - return result;
> - }
> -
> - send_header.command = command;
> -
> - return ustcomm_req(sock,
> - &send_header,
> - (char *)&ch_info,
> - recv_header,
> - recv_data);
> -}
> -
> -int ustcomm_send_buf_req(int sock, char *channel, int ch_cpu,
> - int command,
> - struct ustcomm_header *recv_header,
> - char *recv_data)
> -{
> - struct ustcomm_header send_header;
> - struct ustcomm_buffer_info buf_info;
> - int result;
> -
> - result = ustcomm_pack_buffer_info(&send_header,
> - &buf_info,
> - channel,
> - ch_cpu);
> - if (result< 0) {
> - return result;
> - }
> -
> - send_header.command = command;
> -
> - return ustcomm_req(sock,
> - &send_header,
> - (char *)&buf_info,
> - recv_header,
> - recv_data);
> -}
--
David Goulet
LTTng project, DORSAL Lab.
PGP/GPG : 1024D/16BD8563
BE3C 672B 9331 9796 291A 14C6 4AF7 C14B 16BD 8563
^ permalink raw reply [flat|nested] 3+ messages in thread* [ltt-dev] [UST PATCH 1/3] Kill some unused code in ustcomm.c
2010-11-09 15:31 [ltt-dev] [UST PATCH 1/3] Kill some unused code in ustcomm.c David Goulet
@ 2010-11-09 15:57 ` Nils Carlson
0 siblings, 0 replies; 3+ messages in thread
From: Nils Carlson @ 2010-11-09 15:57 UTC (permalink / raw)
And pulled, thank you!
/Nils
On Tue, 9 Nov 2010, David Goulet wrote:
> Maybe also get rid of the definition in libustcomm/ustcomm.h :)
>
> Acked-by: David Goulet <david.goulet at polymtl.ca>
>
> On 10-11-04 12:54 PM, Nils Carlson wrote:
>>
>> Signed-off-by: Nils Carlson<nils.carlson at ericsson.com>
>> ---
>> libustcomm/ustcomm.c | 49 -------------------------------------------------
>> 1 files changed, 0 insertions(+), 49 deletions(-)
>>
>> diff --git a/libustcomm/ustcomm.c b/libustcomm/ustcomm.c
>> index 2c547ab..fe8fea2 100644
>> --- a/libustcomm/ustcomm.c
>> +++ b/libustcomm/ustcomm.c
>> @@ -775,52 +775,3 @@ int ustcomm_unpack_sock_path(struct ustcomm_sock_path *sock_path_inf)
>> return 0;
>> }
>>
>> -int ustcomm_send_ch_req(int sock, char *channel, int command,
>> - struct ustcomm_header *recv_header,
>> - char *recv_data)
>> -{
>> - struct ustcomm_header send_header;
>> - struct ustcomm_channel_info ch_info;
>> - int result;
>> -
>> - result = ustcomm_pack_channel_info(&send_header,
>> - &ch_info,
>> - channel);
>> - if (result< 0) {
>> - return result;
>> - }
>> -
>> - send_header.command = command;
>> -
>> - return ustcomm_req(sock,
>> - &send_header,
>> - (char *)&ch_info,
>> - recv_header,
>> - recv_data);
>> -}
>> -
>> -int ustcomm_send_buf_req(int sock, char *channel, int ch_cpu,
>> - int command,
>> - struct ustcomm_header *recv_header,
>> - char *recv_data)
>> -{
>> - struct ustcomm_header send_header;
>> - struct ustcomm_buffer_info buf_info;
>> - int result;
>> -
>> - result = ustcomm_pack_buffer_info(&send_header,
>> - &buf_info,
>> - channel,
>> - ch_cpu);
>> - if (result< 0) {
>> - return result;
>> - }
>> -
>> - send_header.command = command;
>> -
>> - return ustcomm_req(sock,
>> - &send_header,
>> - (char *)&buf_info,
>> - recv_header,
>> - recv_data);
>> -}
>
> --
> David Goulet
> LTTng project, DORSAL Lab.
>
> PGP/GPG : 1024D/16BD8563
> BE3C 672B 9331 9796 291A 14C6 4AF7 C14B 16BD 8563
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ltt-dev] [UST PATCH 1/3] Kill some unused code in ustcomm.c
@ 2010-11-04 16:54 Nils Carlson
0 siblings, 0 replies; 3+ messages in thread
From: Nils Carlson @ 2010-11-04 16:54 UTC (permalink / raw)
Signed-off-by: Nils Carlson <nils.carlson at ericsson.com>
---
libustcomm/ustcomm.c | 49 -------------------------------------------------
1 files changed, 0 insertions(+), 49 deletions(-)
diff --git a/libustcomm/ustcomm.c b/libustcomm/ustcomm.c
index 2c547ab..fe8fea2 100644
--- a/libustcomm/ustcomm.c
+++ b/libustcomm/ustcomm.c
@@ -775,52 +775,3 @@ int ustcomm_unpack_sock_path(struct ustcomm_sock_path *sock_path_inf)
return 0;
}
-int ustcomm_send_ch_req(int sock, char *channel, int command,
- struct ustcomm_header *recv_header,
- char *recv_data)
-{
- struct ustcomm_header send_header;
- struct ustcomm_channel_info ch_info;
- int result;
-
- result = ustcomm_pack_channel_info(&send_header,
- &ch_info,
- channel);
- if (result < 0) {
- return result;
- }
-
- send_header.command = command;
-
- return ustcomm_req(sock,
- &send_header,
- (char *)&ch_info,
- recv_header,
- recv_data);
-}
-
-int ustcomm_send_buf_req(int sock, char *channel, int ch_cpu,
- int command,
- struct ustcomm_header *recv_header,
- char *recv_data)
-{
- struct ustcomm_header send_header;
- struct ustcomm_buffer_info buf_info;
- int result;
-
- result = ustcomm_pack_buffer_info(&send_header,
- &buf_info,
- channel,
- ch_cpu);
- if (result < 0) {
- return result;
- }
-
- send_header.command = command;
-
- return ustcomm_req(sock,
- &send_header,
- (char *)&buf_info,
- recv_header,
- recv_data);
-}
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-09 15:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-09 15:31 [ltt-dev] [UST PATCH 1/3] Kill some unused code in ustcomm.c David Goulet
2010-11-09 15:57 ` Nils Carlson
-- strict thread matches above, loose matches on Subject: below --
2010-11-04 16:54 Nils Carlson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox