From: dwt@PolTec.COM (Dennis W. Tokarski)
Subject: [ltt-dev] [PATCH] Fix missing definition of ltt_get_alignment() in kernel/marker.c
Date: Sat, 31 Jan 2009 23:05:39 -0500 [thread overview]
Message-ID: <49851F93.30406@PolTec.COM> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
While looking into problems taking a trace on a dual cpu qemu-i386 VM,
I decided to try a kernel which had ltt turned off in the configuration
but was otherwise the same.
This left me with ltt off but markers still on, and kernel/markers.c
wouldn't build because several of the *trace_mark() calls use
ltt_get_alignment() as an argument. Its definition in ltt-tracer.h
is entirely enclosed within the #ifdef CONFIG_LLT...#endif. I propose
to move it outside. Patch attached.
- --Dennis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFJhR+DDJucIzCImrURAgGLAJ9W7r7hLS5rVvdy/uXLPM05Vk0g6gCgoVi0
7b/k63xy5k0SHbx3KJaBSD8=
=OGm/
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ltt-tracer.h.patch
Type: text/x-patch
Size: 2065 bytes
Desc: not available
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20090131/4d95892a/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ltt-tracer.h.patch.sig
Type: application/pgp-signature
Size: 65 bytes
Desc: not available
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20090131/4d95892a/attachment-0003.pgp>
WARNING: multiple messages have this Message-ID
From: dwt@PolTec.COM (Dennis W. Tokarski)
Subject: [ltt-dev] [PATCH] Fix missing definition of ltt_get_alignment() in kernel/marker.c
Date: Sat, 31 Jan 2009 23:05:39 -0500 [thread overview]
Message-ID: <49851F93.30406@PolTec.COM> (raw)
Message-ID: <20090201040539.oaMfm6YH_Mz9SNWuCnFPE0qtuWEKPmx8nrJYq2FYhrY@z> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
While looking into problems taking a trace on a dual cpu qemu-i386 VM,
I decided to try a kernel which had ltt turned off in the configuration
but was otherwise the same.
This left me with ltt off but markers still on, and kernel/markers.c
wouldn't build because several of the *trace_mark() calls use
ltt_get_alignment() as an argument. Its definition in ltt-tracer.h
is entirely enclosed within the #ifdef CONFIG_LLT...#endif. I propose
to move it outside. Patch attached.
- --Dennis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFJhR+DDJucIzCImrURAgGLAJ9W7r7hLS5rVvdy/uXLPM05Vk0g6gCgoVi0
7b/k63xy5k0SHbx3KJaBSD8=
=OGm/
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ltt-tracer.h.patch
Type: text/x-patch
Size: 2065 bytes
Desc: not available
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20090131/4d95892a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ltt-tracer.h.patch.sig
Type: application/pgp-signature
Size: 65 bytes
Desc: not available
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20090131/4d95892a/attachment-0002.pgp>
WARNING: multiple messages have this Message-ID
From: dwt@PolTec.COM (Dennis W. Tokarski)
Subject: [ltt-dev] [PATCH] Fix missing definition of ltt_get_alignment() in kernel/marker.c
Date: Sat, 31 Jan 2009 23:05:39 -0500 [thread overview]
Message-ID: <49851F93.30406@PolTec.COM> (raw)
Message-ID: <20090201040539.n_36-Entq4xujm-FNmsLzrsvBcV91BGVRZ4Uc9Czt7E@z> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
While looking into problems taking a trace on a dual cpu qemu-i386 VM,
I decided to try a kernel which had ltt turned off in the configuration
but was otherwise the same.
This left me with ltt off but markers still on, and kernel/markers.c
wouldn't build because several of the *trace_mark() calls use
ltt_get_alignment() as an argument. Its definition in ltt-tracer.h
is entirely enclosed within the #ifdef CONFIG_LLT...#endif. I propose
to move it outside. Patch attached.
- --Dennis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFJhR+DDJucIzCImrURAgGLAJ9W7r7hLS5rVvdy/uXLPM05Vk0g6gCgoVi0
7b/k63xy5k0SHbx3KJaBSD8=
=OGm/
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ltt-tracer.h.patch
Type: text/x-patch
Size: 2065 bytes
Desc: not available
URL: <http://lists.casi.polymtl.ca/pipermail/ltt-dev/attachments/20090131/4d95892a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ltt-tracer.h.patch.sig
Type: application/pgp-signature
Size: 65 bytes
Desc: not available
URL: <http://lists.casi.polymtl.ca/pipermail/ltt-dev/attachments/20090131/4d95892a/attachment.pgp>
next reply other threads:[~2009-02-01 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 4:05 Dennis W. Tokarski [this message]
2009-02-01 4:05 ` Dennis W. Tokarski
2009-02-01 4:05 ` Dennis W. Tokarski
2009-02-02 17:07 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49851F93.30406@PolTec.COM \
--to=dwt@poltec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox