Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: pierre-marc.fournier@polymtl.ca (Pierre-Marc Fournier)
Subject: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically
Date: Wed, 07 Jan 2009 09:20:27 -0500	[thread overview]
Message-ID: <4964BA2B.30200@polymtl.ca> (raw)
In-Reply-To: <49646208.7070607@cn.fujitsu.com>

Zhaolei wrote:
> lttctl need debugfs mounted,
> This patch make lttctl mount debugfs automatically when it is not mounted.
> 

Isn't having a utility such as lttctl mount filesystems against standard
unix semantics? Can you give an example of another standard command that
uses a filesystem and that tries to mount it if it isn't already
mounted? My guess is we should warn about the filesystem not being
mounted, but not try to call mount() directly.

> Little cleanup also done(combile 2 getdebugfsmntdir() into one).
> 
> Applies on top of ltt-control-0.63-03012009.
> 




  parent reply	other threads:[~2009-01-07 14:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07  8:04 Zhaolei
2009-01-07  8:09 ` [ltt-dev] [PATCH 2/2] Make lttctl load ltt-trace-control module automatically Zhaolei
2009-01-15  1:20   ` Mathieu Desnoyers
2009-01-07 14:20 ` Pierre-Marc Fournier [this message]
2009-01-08  0:40   ` [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically Zhaolei
2009-01-08 14:44     ` Mathieu Desnoyers
2009-01-09  1:57       ` Zhaolei
2009-01-09  3:30         ` Mathieu Desnoyers
2009-01-13 23:54           ` Greg KH
2009-01-14  2:02             ` Josh Boyer
2009-01-14  5:16             ` Mathieu Desnoyers
2009-01-14  5:54               ` Greg KH
2009-01-15  1:41                 ` Mathieu Desnoyers
2009-01-15  1:20 ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4964BA2B.30200@polymtl.ca \
    --to=pierre-marc.fournier@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox