[ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically

[compudj@krystal.dyndns.org (Mathieu Desnoyers)]

* Zhaolei (zhaolei at cn.fujitsu.com) wrote:
> * From: "Pierre-Marc Fournier" <pierre-marc.fournier@polymtl.ca>
> > Zhaolei wrote:
> >> lttctl need debugfs mounted,
> >> This patch make lttctl mount debugfs automatically when it is not mounted.
> >> 
> > 
> > Isn't having a utility such as lttctl mount filesystems against standard
> > unix semantics? Can you give an example of another standard command that
> > uses a filesystem and that tries to mount it if it isn't already
> > mounted? 
> Hello, Pierre-Marc,
> 
> I can give a an example.
> It is SystemTap.
> 

No offence, but can you find an example which is not explicitly
described as "bad taste" example by many people in the Linux kernel
community ?

Mathieu

> Regards
> Zhaolei
> 
> > My guess is we should warn about the filesystem not being
> > mounted, but not try to call mount() directly.
> > 
> >> Little cleanup also done(combile 2 getdebugfsmntdir() into one).
> >> 
> >> Applies on top of ltt-control-0.63-03012009.
> >> 
> > 
> >
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68