From: jonathan.rajotte-julien@efficios.com (Jonathan Rajotte-Julien)
Subject: [lttng-dev] [PATCH lttng-tools 2/9] Fix: tests: error handling in high throughput limits test
Date: Wed, 15 May 2019 12:31:27 -0400 [thread overview]
Message-ID: <20190515163127.GD14986@joraj-alpa> (raw)
In-Reply-To: <20190503135547.12968-3-mathieu.desnoyers@efficios.com>
> @@ -168,8 +187,7 @@ skip $isroot "Root access is needed to set bandwith limits. Skipping all tests."
> {
>
> # Catch sigint and try to cleanup limits
> - trap interrupt_cleanup SIGTERM
> - trap interrupt_cleanup SIGINT
> + trap interrupt_cleanup SIGTERM SIGINT
>
> BW_LIMITS=(3200 1600 800 400 200 100 50 25)
> for BW in ${BW_LIMITS[@]};
> @@ -177,6 +195,7 @@ skip $isroot "Root access is needed to set bandwith limits. Skipping all tests."
> diag "Test high-throughput with bandwidth limit set to ${BW}kbits"
>
> set_bw_limit $BW
> + ok $? "Setting bandwidth limit"
In case of failure here we should force a reset since it could lead to long
timeout/hang depending on which tc command failed?
This could also be done inside set_bw_limit at each stage.
>
> start_lttng_sessiond
> start_lttng_relayd "-o $TRACE_PATH"
> @@ -185,5 +204,6 @@ skip $isroot "Root access is needed to set bandwith limits. Skipping all tests."
> stop_lttng_relayd
> stop_lttng_sessiond
> reset_bw_limit
> + ok $? "Reset bandwith limits"
> done
> }
> --
> 2.11.0
>
--
Jonathan Rajotte-Julien
EfficiOS
next prev parent reply other threads:[~2019-05-15 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190503135547.12968-1-mathieu.desnoyers@efficios.com>
[not found] ` <20190503135547.12968-8-mathieu.desnoyers@efficios.com>
2019-05-15 15:18 ` [lttng-dev] [PATCH lttng-tools 7/9] epoll/poll compat: expose interruptible API Jonathan Rajotte-Julien
[not found] ` <20190503135547.12968-9-mathieu.desnoyers@efficios.com>
2019-05-15 15:20 ` [lttng-dev] [PATCH lttng-tools 8/9] lttng-ctl: notifications: use epoll()/poll() instead of select() Jonathan Rajotte-Julien
[not found] ` <20190503135547.12968-2-mathieu.desnoyers@efficios.com>
2019-05-15 16:19 ` [lttng-dev] [PATCH lttng-tools 1/9] Improve handling of test SIGTERM/SIGINT Jonathan Rajotte-Julien
2019-05-16 16:00 ` Mathieu Desnoyers
[not found] ` <20190503135547.12968-3-mathieu.desnoyers@efficios.com>
2019-05-15 16:31 ` Jonathan Rajotte-Julien [this message]
2019-05-15 22:36 ` [lttng-dev] [PATCH lttng-tools 2/9] Fix: tests: error handling in high throughput limits test Mathieu Desnoyers
[not found] ` <20190503135547.12968-7-mathieu.desnoyers@efficios.com>
2019-05-15 16:43 ` [lttng-dev] [PATCH lttng-tools 6/9] tests: invoke full_cleanup from script trap handlers, use modprobe -r Jonathan Rajotte-Julien
[not found] ` <20190503135547.12968-6-mathieu.desnoyers@efficios.com>
2019-05-15 16:44 ` [lttng-dev] [PATCH lttng-tools 5/9] Cleanup: test: don't stop relayd twice Jonathan Rajotte-Julien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515163127.GD14986@joraj-alpa \
--to=jonathan.rajotte-julien@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox