[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Jimmy Durand]

2013/8/24 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

> * Jimmy Durand (jimmy.durand.wesolowski at gmail.com) wrote:
> > 2013/8/22 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> >
> > > * Jimmy Durand Wesolowski (jimmy.durand.wesolowski at gmail.com) wrote:
> > > > Hi,
> > > >
> > > >
> > > > Here are some patches to allow installing LTTng-ust out of the system
> > > > directories, ie building with "./configure --prefix", without having
> to
> > > set
> > > > C/CPP/LDFLAGS at both the configure and the make building steps.
> > >
> > > Usually, setting CPPFLAGS/CFLAGS/LDFLAGS at configure time is enough,
> > > e.g.:
> > >
> > > LDFLAGS=/usr/local/lib ./configure
> > >
> > > What feature is this patchset adding that is not covered by the usual
> > > approach ? Or what is it fixing ?
> > >
> > Actually, this is enough for a regular system build, but if you wish to
> > build
> > it in another directory with --prefix=<PATH>, which is the case for
> cross-
> > compiling, this not enough.
>
> It might be a failure of my imagination but.. why is
> CPPFLAGS/CFLAGS/LDFLAGS not enough to get UST to fetch the dependencies
> it needs (e.g. userspace RCU) when they have been installed in
> non-standard paths (because e.g. userspace RCU has been configured with
> a --prefix path for sake of cross-compiling).
>
When building the doc/examples source directories, it seems that the
Makefiles are
not using the compiler and the flags set during the './configure' stage.

Can you give a more detailed use-case that CPPFLAGS/CFLAGS/LDFLAGS fail
> to cover ?
>
Yes, I will send it a complete use case Monday morning (UTC+1).

Thanks,

Thank you for the support,
-- 
Jimmy Durand Wesolowski
Linux System Engineer & amateur photographer
OpenWide
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20130824/c1b66eac/attachment.html>

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Jimmy Durand Wesolowski]

2013/8/24 Jimmy Durand <jimmy.durand.wesolowski at gmail.com>

> 2013/8/24 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
>
>> * Jimmy Durand (jimmy.durand.wesolowski at gmail.com) wrote:
>> > 2013/8/22 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
>> >
>> > > * Jimmy Durand Wesolowski (jimmy.durand.wesolowski at gmail.com) wrote:
>> > > > Hi,
>> > > >
>> > > >
>> > > > Here are some patches to allow installing LTTng-ust out of the
>> system
>> > > > directories, ie building with "./configure --prefix", without
>> having to
>> > > set
>> > > > C/CPP/LDFLAGS at both the configure and the make building steps.
>> > >
>> > > Usually, setting CPPFLAGS/CFLAGS/LDFLAGS at configure time is enough,
>> > > e.g.:
>> > >
>> > > LDFLAGS=/usr/local/lib ./configure
>> > >
>> > > What feature is this patchset adding that is not covered by the usual
>> > > approach ? Or what is it fixing ?
>> > >
>> > Actually, this is enough for a regular system build, but if you wish to
>> > build
>> > it in another directory with --prefix=<PATH>, which is the case for
>> cross-
>> > compiling, this not enough.
>>
>> It might be a failure of my imagination but.. why is
>> CPPFLAGS/CFLAGS/LDFLAGS not enough to get UST to fetch the dependencies
>> it needs (e.g. userspace RCU) when they have been installed in
>> non-standard paths (because e.g. userspace RCU has been configured with
>> a --prefix path for sake of cross-compiling).
>>
> When building the doc/examples source directories, it seems that the
> Makefiles are
> not using the compiler and the flags set during the './configure' stage.
>
> Can you give a more detailed use-case that CPPFLAGS/CFLAGS/LDFLAGS fail
>> to cover ?
>>
> Yes, I will send it a complete use case Monday morning (UTC+1).
>

Here is a quick test, without any of my modifications. I had to pass both
CFLAGS and LDFLAGS to "./configure", as said earlier, which can be
considered
a normal process:
CFLAGS="-I<URCU_BUILD_PATH>/include" \
  CPPFLAGS="-I<URCU_BUILD_PATH>/include" \
  LDFLAGS="-L<URCU_BUILD_PATH>/lib" \
  ./configure --prefix=${PWD}/build

Now, running "make all install", I would expect the build to succeed. But,
in
the "doc/examples" subdirectories, for example "easy-ust", I have the
following error:
../../../include/lttng/tracepoint-rcu.h:26:27: fatal error:
urcu/compiler.h: \
No such file or directory

I have to run "make all" with the CFLAGS set to have a successful build
(actually I even had to add a -I${PWD}/include to the "./configure" step,
'sample_tracepoint.o' would not build otherwise).


Thank you,
-- 
Jimmy Durand Wesolowski
OpenWide R&D engineer
OneAccess
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20130826/eb7f66e0/attachment.html>

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Thomas Petazzoni]

Dear Jimmy Durand Wesolowski,

On Mon, 26 Aug 2013 09:43:49 +0200, Jimmy Durand Wesolowski wrote:

> Here is a quick test, without any of my modifications. I had to pass both
> CFLAGS and LDFLAGS to "./configure", as said earlier, which can be
> considered
> a normal process:
> CFLAGS="-I<URCU_BUILD_PATH>/include" \
>   CPPFLAGS="-I<URCU_BUILD_PATH>/include" \
>   LDFLAGS="-L<URCU_BUILD_PATH>/lib" \
>   ./configure --prefix=${PWD}/build

As said previously, if you're cross-compiling, doing
--prefix=${PWD}/build is completely wrong. --prefix is the directory
where the software will be located when executed on the target, not the
location where the software will be installed when doing 'make install'.

Please document yourself on the difference between --prefix at
configure time and DESTDIR at install time.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Mathieu Desnoyers]

* Thomas Petazzoni (thomas.petazzoni at free-electrons.com) wrote:
> Dear Jimmy Durand Wesolowski,
> 
> On Mon, 26 Aug 2013 09:43:49 +0200, Jimmy Durand Wesolowski wrote:
> 
> > Here is a quick test, without any of my modifications. I had to pass both
> > CFLAGS and LDFLAGS to "./configure", as said earlier, which can be
> > considered
> > a normal process:
> > CFLAGS="-I<URCU_BUILD_PATH>/include" \
> >   CPPFLAGS="-I<URCU_BUILD_PATH>/include" \
> >   LDFLAGS="-L<URCU_BUILD_PATH>/lib" \
> >   ./configure --prefix=${PWD}/build
> 
> As said previously, if you're cross-compiling, doing
> --prefix=${PWD}/build is completely wrong. --prefix is the directory
> where the software will be located when executed on the target, not the
> location where the software will be installed when doing 'make install'.
> 
> Please document yourself on the difference between --prefix at
> configure time and DESTDIR at install time.

There appears to be a problem introduced recently by the new
doc/examples in lttng-ust.

If I make uninstall both userspace RCU and UST from my system, then:

(urcu)
./configure --with-sysroot=/tmp/test
make clean
make
DESTDIR=/tmp/test make install

(lttng-ust)
LDFLAGS=-L/tmp/test/usr/local/lib CPPFLAGS=-I/tmp/test/usr/local/include \
                ./configure --with-sysroot=/tmp/test
make clean
make

The last make fails with:

for subdir in easy-ust demo gen-tp hello-static-lib; do \
		cd $subdir && make AM_CPPFLAGS="-I../../../include/" AM_LDFLAGS='-L../../../liblttng-ust/.libs/ -Wl,-rpath="/home/compudj/git/lttng-ust/doc/examples/../../liblttng-ust/.libs/"' LTTNG_GEN_TP_PATH="../../../tools/"  all; cd ..; \
	done
make[4]: Entering directory `/home/compudj/git/lttng-ust/doc/examples/easy-ust'
gcc  -I.  -I../../../include/ \
		 -c -o sample.o sample.c
In file included from ../../../include/lttng/tracepoint.h:29:0,
                 from sample_component_provider.h:62,
                 from sample.c:31:
../../../include/lttng/tracepoint-rcu.h:26:27: fatal error: urcu/compiler.h: No such file or directory
compilation terminated.
make[4]: *** [sample.o] Error 1
make[4]: Leaving directory `/home/compudj/git/lttng-ust/doc/examples/easy-ust'
make[4]: Entering directory `/home/compudj/git/lttng-ust/doc/examples/demo'

The following patch fixes part of the problem:

diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index 8c4901b..d26e520 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -45,7 +45,7 @@ all-local:
 		done; \
 	fi
 	for subdir in $(SUBDIRS_PROXY); do \
-		cd $$subdir && $(MAKE) AM_CPPFLAGS="-I../../../include/" AM_LDFLAGS='-L../../../liblttng-ust/.libs/ -Wl,-rpath="$(PWD)/../../liblttng-ust/.libs/"' LTTNG_GEN_TP_PATH="../../../tools/" $(AM_MAKEFLAGS) all; cd ..; \
+		cd $$subdir && $(MAKE) AM_CPPFLAGS="$(CPPFLAGS) -I../../../include/" AM_LDFLAGS='$(LDFLAGS) -L../../../liblttng-ust/.libs/ -Wl,-rpath="$(PWD)/../../liblttng-ust/.libs/"' LTTNG_GEN_TP_PATH="../../../tools/" $(AM_MAKEFLAGS) all; cd ..; \
 	done
 
 clean-local:

Now I just have to figure out how to teach lttng-gen-tp about CPPFLAGS
:-/

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Jimmy Durand Wesolowski]

2013/8/26 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

> Now I just have to figure out how to teach lttng-gen-tp about CPPFLAGS
> :-/
>

My patch is correcting this, and the new version does take your
comment into account.


Thank you,
-- 
Jimmy Durand Wesolowski
OpenWide R&D engineer
OneAccess
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20130826/8f51cd6b/attachment.html>

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Mathieu Desnoyers]

* Jimmy Durand Wesolowski (jimmy.durand.wesolowski at gmail.com) wrote:
> 2013/8/26 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> 
> > Now I just have to figure out how to teach lttng-gen-tp about CPPFLAGS
> > :-/
> >
> 
> My patch is correcting this, and the new version does take your
> comment into account.

Actually, I just pushed a fix for this into master (I had to test all
this myself to understand what happens):

commit 9ec23f2e52b3b0bd8b80afbe2e8e8ae1ab222c6b
Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Date:   Mon Aug 26 11:14:56 2013 -0400

    Fix: doc/examples cross-build
    
    We need to pass automake's CPPFLAGS and LDFLAGS to examples. Add CFLAGS
    too for completeness.
    
    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

We still have issues with lttng-gen-tp though: I'm looking for a way to
change its Makefile so it adds "AM_CPPFLAGS" to the CFLAGS passed to the
compiler. Ideas ?

Thanks for pointing out this issue,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Mathieu Desnoyers]

* Mathieu Desnoyers (mathieu.desnoyers at efficios.com) wrote:
> * Jimmy Durand Wesolowski (jimmy.durand.wesolowski at gmail.com) wrote:
> > 2013/8/26 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> > 
> > > Now I just have to figure out how to teach lttng-gen-tp about CPPFLAGS
> > > :-/
> > >
> > 
> > My patch is correcting this, and the new version does take your
> > comment into account.
> 
> Actually, I just pushed a fix for this into master (I had to test all
> this myself to understand what happens):
> 
> commit 9ec23f2e52b3b0bd8b80afbe2e8e8ae1ab222c6b
> Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> Date:   Mon Aug 26 11:14:56 2013 -0400
> 
>     Fix: doc/examples cross-build
>     
>     We need to pass automake's CPPFLAGS and LDFLAGS to examples. Add CFLAGS
>     too for completeness.
>     
>     Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> 
> We still have issues with lttng-gen-tp though: I'm looking for a way to
> change its Makefile so it adds "AM_CPPFLAGS" to the CFLAGS passed to the
> compiler. Ideas ?

I got it to work. See those commits in master:

commit 256175cffb00b15543bd49a4268e6c528bd51fce
Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Date:   Mon Aug 26 11:26:09 2013 -0400

    doc/examples/gen-tp: pass automake CPPFLAGS/CFLAGS/LDFLAGS
    
    Fix cross-build.
    
    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

commit 170423b056ecdef441820a54be350605e4dc8951
Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Date:   Mon Aug 26 11:24:26 2013 -0400

    tools/lttng-gen-tp: honor CPPFLAGS and LDFLAGS
    
    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Jimmy Durand Wesolowski]

2013/8/26 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

> I got it to work. See those commits in master:
>
Great, thank you.
I just got a little problem about libraries, and took only a chunk of my
patch
to correct it.
I also kept the --with-rcu-path (renamed from --with-rcu-prefix) configure
option, but if you do not like it, of course, feel free to remove it.
I will send this in a moment.


Thank you,
-- 
Jimmy Durand Wesolowski
OpenWide R&D engineer
OneAccess
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20130826/48e00a25/attachment.html>

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Mathieu Desnoyers]

* Jimmy Durand Wesolowski (jimmy.durand.wesolowski at gmail.com) wrote:
> 2013/8/26 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> 
> > I got it to work. See those commits in master:
> >
> Great, thank you.
> I just got a little problem about libraries, and took only a chunk of my
> patch
> to correct it.
> I also kept the --with-rcu-path (renamed from --with-rcu-prefix) configure
> option, but if you do not like it, of course, feel free to remove it.
> I will send this in a moment.

Please make sure you detail your use-case (how to reproduce the issue)
along with your patch.

Thanks,

Mathieu

> 
> 
> Thank you,
> -- 
> Jimmy Durand Wesolowski
> OpenWide R&D engineer
> OneAccess

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Jimmy Durand Wesolowski]

2013/8/26 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

> * Jimmy Durand Wesolowski (jimmy.durand.wesolowski at gmail.com) wrote:
> > 2013/8/26 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> >
> > > I got it to work. See those commits in master:
> > >
> > Great, thank you.
> > I just got a little problem about libraries, and took only a chunk of my
> > patch
> > to correct it.
> > I also kept the --with-rcu-path (renamed from --with-rcu-prefix)
> configure
> > option, but if you do not like it, of course, feel free to remove it.
> > I will send this in a moment.
>
> Please make sure you detail your use-case (how to reproduce the issue)
> along with your patch.
>
> Thanks,
>

My mistake, I did a 'git clean' and retried, your last patches correct the
problem. Only my --with-rcu-path patch would be useful, but maybe not enough
to be put in the project.


Thank you,
-- 
Jimmy Durand Wesolowski
OpenWide R&D engineer
OneAccess
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20130827/0ec62f7c/attachment.html>

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Jimmy Durand Wesolowski]

2013/8/26 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

> Dear Jimmy Durand Wesolowski,

Dear Thomas Petazzoni,



> On Mon, 26 Aug 2013 09:43:49 +0200, Jimmy Durand Wesolowski wrote:
>
> > Here is a quick test, without any of my modifications. I had to pass both
> > CFLAGS and LDFLAGS to "./configure", as said earlier, which can be
> > considered
> > a normal process:
> > CFLAGS="-I<URCU_BUILD_PATH>/include" \
> >   CPPFLAGS="-I<URCU_BUILD_PATH>/include" \
> >   LDFLAGS="-L<URCU_BUILD_PATH>/lib" \
> >   ./configure --prefix=${PWD}/build
>
> As said previously, if you're cross-compiling, doing
> --prefix=${PWD}/build is completely wrong. --prefix is the directory
> where the software will be located when executed on the target, not the
> location where the software will be installed when doing 'make install'.
>
Thank you for this information, I shamefully did not remember this, and I
am a buildroot user myself... I will not be using --prefix for cross-
compilation anymore, thank you.

Nevertheless, I did not say that LTTng cannot be cross-compiled without
these changes, but it needs flags at the 'configure' step, and at the
'make' one, as I said earlier, which DESTDIR will not correct, since the
the flags are not given to the sub-Makefiles.


Thank you for the correction,
-- 
Jimmy Durand Wesolowski
OpenWide R&D engineer
OneAccess
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20130826/8cb7bbda/attachment.html>

[lttng-dev] [LTTNG][LTTng-ust] "Out of system" building patches.

[Thomas Petazzoni]

Dear Jimmy Durand,

On Sat, 24 Aug 2013 17:34:16 +0200, Jimmy Durand wrote:

> > What feature is this patchset adding that is not covered by the usual
> > approach ? Or what is it fixing ?
> >
> Actually, this is enough for a regular system build, but if you wish to
> build
> it in another directory with --prefix=<PATH>, which is the case for cross-
> compiling, this not enough.

When I hear someone say that --prefix=... is needed for
cross-compilation, it's usually an indication that the
cross-compilation is done incorrectly.

--prefix indicates the location where the software will be *executed*
on the target. So even when you're cross-compiling, the default of
--prefix=/usr or --prefix=/usr/local is fine.

All what you need to do is pass
DESTDIR=/your/temporary/location/on/your/build/machine when doing make
install.

Buildroot (http://buildroot.org), which some of your colleagues at
OpenWide are using, does cross-compile LTTng without such changes to
LTTng build system.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com